From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34540)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1Y3kOA-0005TB-5K
	for qemu-devel@nongnu.org; Wed, 24 Dec 2014 06:46:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1Y3kO4-0008B7-0v
	for qemu-devel@nongnu.org; Wed, 24 Dec 2014 06:46:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1Y3kO3-0008B3-Pn
	for qemu-devel@nongnu.org; Wed, 24 Dec 2014 06:45:55 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBOBjs1D016281
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 24 Dec 2014 06:45:54 -0500
Message-ID: <549AA770.2080504@redhat.com>
Date: Wed, 24 Dec 2014 13:45:52 +0200
From: Marcel Apfelbaum <marcel@redhat.com>
MIME-Version: 1.0
References: <5499E8D4.4010903@redhat.com>
In-Reply-To: <5499E8D4.4010903@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] '-usb' regressed by 49d2e648 ("machine: remove
 qemu_machine_opts global list")
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>
Cc: qemu devel list <qemu-devel@nongnu.org>

On 12/24/2014 12:12 AM, Laszlo Ersek wrote:
> Apologies if this problem is known. After building qemu at ab0302ee:
The problem is not known.
Thanks for finding it and testing it!
Marcel

>
> $ qemu-system-x86_64 -usb
>
> qemu-system-x86_64: util/qemu-option.c:387: qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed.
>
> The stack is
>
> #0  0x00007ffff1e945c9 in raise () from /lib64/libc.so.6
> #1  0x00007ffff1e95cd8 in abort () from /lib64/libc.so.6
> #2  0x00007ffff1e8d536 in __assert_fail_base () from /lib64/libc.so.6
> #3  0x00007ffff1e8d5e2 in __assert_fail () from /lib64/libc.so.6
> #4  0x00005555559660f5 in qemu_opt_get_bool_helper (opts=0x5555562b51f0, name=0x55555598a4af "usb", defval=false, del=false) at util/qemu-option.c:387
> #5  0x000055555596614d in qemu_opt_get_bool (opts=0x5555562b51f0, name=0x55555598a4af "usb", defval=false) at util/qemu-option.c:397
> #6  0x0000555555715d23 in usb_enabled (default_usb=false) at vl.c:1002
> #7  0x000055555568d7bc in pc_init1 (machine=0x5555562c22f0, pci_enabled=1, kvmclock_enabled=1) at hw/i386/pc_piix.c:277
> #8  0x000055555568d94e in pc_init_pci (machine=0x5555562c22f0) at hw/i386/pc_piix.c:308
> #9  0x000055555571e8d4 in main (argc=2, argv=0x7fffffffd1d8, envp=0x7fffffffd1f0) at vl.c:4217
>
> Bisection fingers 49d2e648.
>
> This is very visible with libvirt.
>
> Thanks
> Laszlo
>