From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexander Graf <agraf@suse.de>, Drew Jones <drjones@redhat.com>,
Laszlo Ersek <lersek@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu devel list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write()
Date: Wed, 31 Dec 2014 20:25:12 +0100 [thread overview]
Message-ID: <54A44D98.4070806@redhat.com> (raw)
In-Reply-To: <CAFEAcA8cgb1s34Rw7MPMmCi5QKWCKyP+FueR-VUkF0JRK6XwRg@mail.gmail.com>
On 31/12/2014 18:29, Peter Maydell wrote:
> On 31 December 2014 at 16:23, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> $ arm-softmmu/qemu-system-arm -M virt -machine accel=qtest \
>> -qtest stdio -uuid 4600cb32-38ec-4b2f-8acb-81c6ea54f2d8
>> writew 0x9020008 0x0200
>> readl 0x9020000
>>
>> The readl should return "OK 0x000000004600cb32".
>
> On BE ppc64 host I get:
> OK 0x0000000032cb0046
> with or without Laszlo's patch.
>
> On LE x86-64 host I get
> OK 0x000000004600cb32
> without the patch, and
> OK 0x0000000032cb0046
> with it.
>
> So I think that the patch is good (in that it removes a host-endian
> dependency which we should not have) and your intuition for the
> correct result is possibly not so good :-)
Indeed. I give up until at least the end of the holiday break.
Paolo
next prev parent reply other threads:[~2014-12-31 19:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 11:21 [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write() Laszlo Ersek
2014-12-31 13:20 ` Paolo Bonzini
2014-12-31 14:07 ` Laszlo Ersek
2014-12-31 15:17 ` Peter Maydell
2014-12-31 16:23 ` Paolo Bonzini
2014-12-31 17:04 ` Laszlo Ersek
2014-12-31 17:56 ` Paolo Bonzini
2014-12-31 17:29 ` Peter Maydell
2014-12-31 19:25 ` Paolo Bonzini [this message]
2014-12-31 19:32 ` Laszlo Ersek
2014-12-31 16:27 ` Laszlo Ersek
2014-12-31 17:17 ` Peter Maydell
2014-12-31 17:37 ` Peter Maydell
2014-12-31 17:59 ` Laszlo Ersek
2014-12-31 18:08 ` Ard Biesheuvel
2014-12-31 18:25 ` Peter Maydell
2015-01-01 10:27 ` Ard Biesheuvel
2014-12-31 18:26 ` Laszlo Ersek
2014-12-31 17:44 ` Peter Maydell
2014-12-31 17:58 ` Laszlo Ersek
2014-12-31 18:22 ` Laszlo Ersek
2015-01-05 15:24 ` Peter Maydell
2015-01-05 15:33 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A44D98.4070806@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=drjones@redhat.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).