From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y74zk-0003yU-BQ for qemu-devel@nongnu.org; Fri, 02 Jan 2015 11:22:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y74zf-0004pH-Cm for qemu-devel@nongnu.org; Fri, 02 Jan 2015 11:22:36 -0500 Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:47037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y74zf-0004pD-67 for qemu-devel@nongnu.org; Fri, 02 Jan 2015 11:22:31 -0500 Received: by mail-wg0-f49.google.com with SMTP id n12so24148833wgh.8 for ; Fri, 02 Jan 2015 08:22:30 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54A6C5C3.60704@redhat.com> Date: Fri, 02 Jan 2015 17:22:27 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1419353600-30519-1-git-send-email-pbonzini@redhat.com> <20150102140052.GK10823@stefanha-thinkpad.redhat.com> In-Reply-To: <20150102140052.GK10823@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, stefanha@redhat.com On 02/01/2015 15:00, Stefan Hajnoczi wrote: >>> This cleanup function gets in the way of making the >>> NetClientStates for the NIC hold an object_ref reference to >>> the object, so get rid of it. > This patch does not drop NetClientInfo->cleanup() and clean up > net.c. Do you have plans for a follow-up patch? No, it is still in use by backends in net/. Only NICs do not need it. Paolo