From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y89el-0002yX-BV for qemu-devel@nongnu.org; Mon, 05 Jan 2015 10:33:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y89eh-0007cM-DD for qemu-devel@nongnu.org; Mon, 05 Jan 2015 10:33:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y89eh-0007bx-6e for qemu-devel@nongnu.org; Mon, 05 Jan 2015 10:33:19 -0500 Message-ID: <54AAAEB7.80604@redhat.com> Date: Mon, 05 Jan 2015 16:33:11 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1420024880-15416-1-git-send-email-lersek@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] fw_cfg: fix endianness in fw_cfg_data_mem_read() / _write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu devel list , Paolo Bonzini , Drew Jones , Alexander Graf , Gerd Hoffmann On 01/05/15 16:24, Peter Maydell wrote: > On 31 December 2014 at 11:21, Laszlo Ersek wrote: >> (1) Let's contemplate what device endianness means > > ...let's not, I value my sanity :-) Lol. :) I'm happy to have sacrificed mine for this matter! ;) >> hw/nvram/fw_cfg.c | 41 +++++++---------------------------------- >> 1 file changed, 7 insertions(+), 34 deletions(-) > > Reviewed-by: Peter Maydell > > and tested on BE host, and applied to target-arm.next. Yay! (Also -- do you tend to push that branch too? I've been stalking it in for a few days now but I'm not seeing new commits.) Thanks! Laszlo