From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8A4q-0006xO-3g for qemu-devel@nongnu.org; Mon, 05 Jan 2015 11:00:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8A4i-0006jv-0T for qemu-devel@nongnu.org; Mon, 05 Jan 2015 11:00:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8A4h-0006jd-Q9 for qemu-devel@nongnu.org; Mon, 05 Jan 2015 11:00:11 -0500 Message-ID: <54AAB504.40604@redhat.com> Date: Mon, 05 Jan 2015 09:00:04 -0700 From: Eric Blake MIME-Version: 1.0 References: <1419916451-49258-5-git-send-email-sfeldma@gmail.com> In-Reply-To: <1419916451-49258-5-git-send-email-sfeldma@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9phwaHc1Tw8ecDNbTTHtJi5aBWsUR2r05" Subject: Re: [Qemu-devel] [PATCH 04/10] rocker: add register programming guide List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com, qemu-devel@nongnu.org, jiri@resnulli.us, roopa@cumulusnetworks.com, john.fastabend@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9phwaHc1Tw8ecDNbTTHtJi5aBWsUR2r05 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/29/2014 10:14 PM, sfeldma@gmail.com wrote: > From: Scott Feldman >=20 > This is the register programming guide for the Rocker device. It's int= ended > for driver writers and device writers. It covers the device's PCI spac= e, > the register set, DMA interface, and interrupts. >=20 > Signed-off-by: Scott Feldman > Signed-off-by: Jiri Pirko > --- > hw/net/rocker/reg_guide.txt | 957 +++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 957 insertions(+) > create mode 100644 hw/net/rocker/reg_guide.txt >=20 > diff --git a/hw/net/rocker/reg_guide.txt b/hw/net/rocker/reg_guide.txt > new file mode 100644 > index 0000000..21ed9f7 > --- /dev/null > +++ b/hw/net/rocker/reg_guide.txt > @@ -0,0 +1,957 @@ > +Rocker Network Switch Register Programming Guide > +Scott Feldman > +Neil Horman > +Version 0.11, 12/29/2014 > + Missing a copyright and license clause. Although this means that it defaults to GPLv2+, per the top-level files, it's better to be explicit (especially if you intended a different license). > + > +XXXXX this section needs work A generation bit in each descriptors com= p_err You'll want to fix this in your v2 patch. > +field marks hardware's progression through the descriptor ring. Each = time the > +ring wraps, the generation bit is toggled. The generation bit allows = software > +to know which descriptors are DMA complete. Software must also toggle= its > +sense of the generation bit each pass through the ring to remain synch= ronized > +with hardware. Hardware will write '1' to generation bit on first pas= s through > +ring, so software should zero-set descriptor ring memory to be syncron= ized with s/syncronized/synchronized/ > + > +Interrupt credits > +^^^^^^^^^^^^^^^^^ > + > +masked but the device generates an interrupt, signally the driver that= more s/signally/signaling/ > +outstansing work is available. s/outstansing/outstanding/ > + > +Various buffer address and sizes should be tested to verify no address= boundary > +issue exists. In particular, buffers that start on odd-8-byte boudary= and/or s/boudary/boundary/ > +SECTION 8: CPU Packet Processing > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > + > +For packets ingressing on switch ports that are not forwarded by the s= witch but > +rather directed to the host CPU for further processing are delievered = in the s/delievered/delivered/ > +Rx Packet Processing > +-------------------- > + > +For packets ingressing on switch ports that are not forwarded by the s= witch but > +rather directed to the host CPU for further processing are delievered = in the again --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9phwaHc1Tw8ecDNbTTHtJi5aBWsUR2r05 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUqrUEAAoJEKeha0olJ0Nqc7IH/RHXksevpWlZLAO83QzYrDPr WAVIhIWNxNPA3kRhmfxui1blxVrFKwAn5JA7VqdoLRCZXaZ8qJNgnE0ZLlhLFqXq GcIN66APyyH4EOzCkHovRkwK1E/yHgJ2WqoK+6uEtln2HdIHU60o7jA6CHMgl3jF dutSzOWakz2fEFrwJOrPSogQmGPvh/br0X2SD0Is3J5YDBx7cC81f1/zgRoHiMEt 6ZJWAWK9Kt6M8+HrIdyoCZOrZhNG1lqREHm8rb37Xhwcs4O1S+fd9X1XDbljGquV wpNMSSSIWPoLPML1DCUA7AafflMoByupoOilu7gGwgD+HZQnX2oudOujJPtoMNE= =Hz/Y -----END PGP SIGNATURE----- --9phwaHc1Tw8ecDNbTTHtJi5aBWsUR2r05--