Re: [Qemu-devel] [PATCH 08/10] qmp: add rocker device support

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2979 bytes --]

On 01/04/2015 02:16 PM, Scott Feldman wrote:
> On Fri, Jan 2, 2015 at 3:56 PM, Eric Blake <eblake@redhat.com> wrote:
>> On 12/29/2014 10:14 PM, sfeldma@gmail.com wrote:
>>> From: Scott Feldman <sfeldma@gmail.com>
>>
>> [your message came through as a top-level thread instead of in-reply-to
>> the 0/10 cover letter; please see if you can fix that before the next
>> submission]
> 
> Looks like I want git send-email options --no-chain-reply-to and
> --thread, correct?

When I use git send-email, the defaults just work.  But I don't know if
there is something in your ~/.gitconfig that changes the defaults, so I
also don't know if those options would restore it back to the default.
All I can suggest is experimenting with sending a test series to
yourself to see if you got settings right, before sending to the list.

You can also update the wiki if you find out what was different for your
case, and where adding options got it fixed:

http://wiki.qemu.org/Contribute/SubmitAPatch


>>> +             '*tunnel_id': 'uint32', '*vlan_id': 'uint16',
>>> +             '*eth_type': 'uint16', '*eth_src': 'str', '*eth_dst': 'str',
>>> +             '*ip_proto': 'uint8', '*ip_tos': 'uint8', '*ip_dst': 'str' } }
>>
>> Is 'str' the right type for IP addresses, or should it be a more
>> specific type?
> 
> String, using dotted-decimal notation seems best for user and script
> parsing.  If it's encoded as native u32 then we need to say if it's
> host-byte-order or network-byte-order.

I can live with string if nothing is better; there's always the
possibility of an array of uint8, rather than trying to encode as a
native u32, but the further we get from normal notation, the harder it
gets to visualize what is going on.  Just throwing it out to make sure
we think about it.


>>> +++ b/qmp-commands.hx
>>> @@ -3860,3 +3860,27 @@ Move mouse pointer to absolute coordinates (20000, 400).
>>>  <- { "return": {} }
>>>
>>>  EQMP
>>> +
>>> +    {
>>> +        .name       = "rocker",
>>> +        .args_type  = "name:s",
>>> +        .mhandler.cmd_new = qmp_marshal_input_rocker,
>>> +    },
>>> +
>>
>> Could you also provide example exchanges for each command added (what
>> the user passes in, and what qemu responds)?
> 
> Provide here or in the commit msg?  Or in the code?  Here's an example session:

In the .hx file.  Plenty of other examples in that file to see what
format they use.

> 
> (qemu) rocker sw1
> name: sw1
> id: 0x0000013512005452
> ports: 4
> 
> (qemu) rocker-ports sw1
>             ena/    speed/ auto
>       port  link    duplex neg?
>      sw1.1  up     10G  FD  No
>      sw1.2  up     10G  FD  No
>      sw1.3  !ena   10G  FD  No
>      sw1.4  !ena   10G  FD  No

That's the HMP representation; I'm asking about the QMP representation
(the JSON exchange).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]