From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8BB6-0002fr-75 for qemu-devel@nongnu.org; Mon, 05 Jan 2015 12:10:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8BB1-0000j2-Pt for qemu-devel@nongnu.org; Mon, 05 Jan 2015 12:10:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8BB1-0000in-It for qemu-devel@nongnu.org; Mon, 05 Jan 2015 12:10:47 -0500 Message-ID: <54AAC590.3010705@redhat.com> Date: Mon, 05 Jan 2015 10:10:40 -0700 From: Eric Blake MIME-Version: 1.0 References: <1419916451-49258-9-git-send-email-sfeldma@gmail.com> <54A7302E.50807@redhat.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Lxv8wSwp0p2NP7LtLQVks31bpm6cOHLhP" Subject: Re: [Qemu-devel] [PATCH 08/10] qmp: add rocker device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Feldman Cc: john fastabend , Roopa Prabhu , =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Lxv8wSwp0p2NP7LtLQVks31bpm6cOHLhP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/04/2015 02:16 PM, Scott Feldman wrote: > On Fri, Jan 2, 2015 at 3:56 PM, Eric Blake wrote: >> On 12/29/2014 10:14 PM, sfeldma@gmail.com wrote: >>> From: Scott Feldman >> >> [your message came through as a top-level thread instead of in-reply-t= o >> the 0/10 cover letter; please see if you can fix that before the next >> submission] >=20 > Looks like I want git send-email options --no-chain-reply-to and > --thread, correct? When I use git send-email, the defaults just work. But I don't know if there is something in your ~/.gitconfig that changes the defaults, so I also don't know if those options would restore it back to the default. All I can suggest is experimenting with sending a test series to yourself to see if you got settings right, before sending to the list. You can also update the wiki if you find out what was different for your case, and where adding options got it fixed: http://wiki.qemu.org/Contribute/SubmitAPatch >>> + '*tunnel_id': 'uint32', '*vlan_id': 'uint16', >>> + '*eth_type': 'uint16', '*eth_src': 'str', '*eth_dst': '= str', >>> + '*ip_proto': 'uint8', '*ip_tos': 'uint8', '*ip_dst': 's= tr' } } >> >> Is 'str' the right type for IP addresses, or should it be a more >> specific type? >=20 > String, using dotted-decimal notation seems best for user and script > parsing. If it's encoded as native u32 then we need to say if it's > host-byte-order or network-byte-order. I can live with string if nothing is better; there's always the possibility of an array of uint8, rather than trying to encode as a native u32, but the further we get from normal notation, the harder it gets to visualize what is going on. Just throwing it out to make sure we think about it. >>> +++ b/qmp-commands.hx >>> @@ -3860,3 +3860,27 @@ Move mouse pointer to absolute coordinates (20= 000, 400). >>> <- { "return": {} } >>> >>> EQMP >>> + >>> + { >>> + .name =3D "rocker", >>> + .args_type =3D "name:s", >>> + .mhandler.cmd_new =3D qmp_marshal_input_rocker, >>> + }, >>> + >> >> Could you also provide example exchanges for each command added (what >> the user passes in, and what qemu responds)? >=20 > Provide here or in the commit msg? Or in the code? Here's an example = session: In the .hx file. Plenty of other examples in that file to see what format they use. >=20 > (qemu) rocker sw1 > name: sw1 > id: 0x0000013512005452 > ports: 4 >=20 > (qemu) rocker-ports sw1 > ena/ speed/ auto > port link duplex neg? > sw1.1 up 10G FD No > sw1.2 up 10G FD No > sw1.3 !ena 10G FD No > sw1.4 !ena 10G FD No That's the HMP representation; I'm asking about the QMP representation (the JSON exchange). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Lxv8wSwp0p2NP7LtLQVks31bpm6cOHLhP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUqsWQAAoJEKeha0olJ0Nq8qAIAJx/IEG5qdwLMBy461VoUtmT Ii3phQNggTXSLMv/i4qS823SgVVPjmW4xWA/KawmKP3yJ+3mVUwtm9Wjns165n2z 9NPrWCMDt/SNrkMqZQNSbqmvAwva97zZszGl57Tdl6r56/9YmK2NSoFh36QF36Op BKqLaQCXO6KHN1xmWIcro97D4YjFh2Yo4qDjT2yS/Uby+nUD85ZCXwEiZoQIGq1Z vMKzUEDTakes87Mvwf5p1WMi2xW/4KNQi2Sl+K/rKMrcm7fLgNZV1WjXRiZzguvn fVSwqK9iAilyjOti1okZ/F56SvCmXicdtqfrh7BUAw+eVTZgksTRVBbNKKoMOP4= =4oeU -----END PGP SIGNATURE----- --Lxv8wSwp0p2NP7LtLQVks31bpm6cOHLhP--