From: Eric Blake <eblake@redhat.com>
To: Scott Feldman <sfeldma@gmail.com>
Cc: "john fastabend" <john.fastabend@gmail.com>,
"Roopa Prabhu" <roopa@cumulusnetworks.com>,
"Jiří Pírko" <jiri@resnulli.us>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 08/10] qmp: add rocker device support
Date: Mon, 05 Jan 2015 10:11:15 -0700 [thread overview]
Message-ID: <54AAC5B3.5000100@redhat.com> (raw)
In-Reply-To: <CAE4R7bDK2=qLfpG3a8_rT5UtxajbiQ3mFGsE1yHOOqd22uqt1g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On 01/04/2015 02:24 PM, Scott Feldman wrote:
> On Sun, Jan 4, 2015 at 1:16 PM, Scott Feldman <sfeldma@gmail.com> wrote:
>> On Fri, Jan 2, 2015 at 3:56 PM, Eric Blake <eblake@redhat.com> wrote:
>>> On 12/29/2014 10:14 PM, sfeldma@gmail.com wrote:
>>>> From: Scott Feldman <sfeldma@gmail.com>
>>>
>>> In this mail, I'll review just the QMP interface portion:
>
> Thanks for review, BTW.
>
> Question: should these rocker defs be moved to qapi/rocker.json, and
> included in top-level qapi-schema.json?
Up to you, if you think they are big enough and useful enough to be
broken into a separate file.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-01-05 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 5:14 [Qemu-devel] [PATCH 08/10] qmp: add rocker device support sfeldma
2015-01-02 23:56 ` Eric Blake
2015-01-04 21:16 ` Scott Feldman
2015-01-04 21:24 ` Scott Feldman
2015-01-05 17:11 ` Eric Blake [this message]
2015-01-05 17:10 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AAC5B3.5000100@redhat.com \
--to=eblake@redhat.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).