From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8BBf-0003Pn-MF for qemu-devel@nongnu.org; Mon, 05 Jan 2015 12:11:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8BBY-0000nj-Tj for qemu-devel@nongnu.org; Mon, 05 Jan 2015 12:11:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8BBY-0000nc-Mc for qemu-devel@nongnu.org; Mon, 05 Jan 2015 12:11:20 -0500 Message-ID: <54AAC5B3.5000100@redhat.com> Date: Mon, 05 Jan 2015 10:11:15 -0700 From: Eric Blake MIME-Version: 1.0 References: <1419916451-49258-9-git-send-email-sfeldma@gmail.com> <54A7302E.50807@redhat.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sxeu5mMatsgRxONaeF8fewQJAwUu9E6Co" Subject: Re: [Qemu-devel] [PATCH 08/10] qmp: add rocker device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Feldman Cc: john fastabend , Roopa Prabhu , =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sxeu5mMatsgRxONaeF8fewQJAwUu9E6Co Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/04/2015 02:24 PM, Scott Feldman wrote: > On Sun, Jan 4, 2015 at 1:16 PM, Scott Feldman wrote= : >> On Fri, Jan 2, 2015 at 3:56 PM, Eric Blake wrote: >>> On 12/29/2014 10:14 PM, sfeldma@gmail.com wrote: >>>> From: Scott Feldman >>> >>> In this mail, I'll review just the QMP interface portion: >=20 > Thanks for review, BTW. >=20 > Question: should these rocker defs be moved to qapi/rocker.json, and > included in top-level qapi-schema.json? Up to you, if you think they are big enough and useful enough to be broken into a separate file. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sxeu5mMatsgRxONaeF8fewQJAwUu9E6Co Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUqsWzAAoJEKeha0olJ0NqtmEH/ijqVtEuZlf/WEFMUYamy8FK b36hxjFhzTaecf7Nw9VbvAR+qEdmwCacWKznJVtZ2d9HAZOXeX5jQDfhu8g57dcB WnB3qo0noxBNtWxMxIp88Sk2r268vIscxt5vip8iDsKsg2Kl2mKxbyQCvdbN90oH bYIEgIoV3Q1pMQw88kFHXAKENY19p+rNgGDHlfiQEj+dU7oR4VFL9KMK7ExnqXzk eaJ+gEm+yHqa5al0fJrCOnZ+kgCByKEbz4tVk2R5clm0SIVvqfJfWSucyihEHqqW EZSC49SllW1Vh4/SUrJPDmawNx8cL8xLUcd9eaSE5Bs7uS1edOwCbRgDJFGQ3Lc= =3MLc -----END PGP SIGNATURE----- --sxeu5mMatsgRxONaeF8fewQJAwUu9E6Co--