From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
David Morrison <dmorrison@invlim.com>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] exec.c: Drop TARGET_HAS_ICE define and checks
Date: Mon, 05 Jan 2015 11:52:50 -0800 [thread overview]
Message-ID: <54AAEB92.4040602@twiddle.net> (raw)
In-Reply-To: <1420484960-32365-1-git-send-email-peter.maydell@linaro.org>
On 01/05/2015 11:09 AM, Peter Maydell wrote:
> The TARGET_HAS_ICE #define is intended to indicate whether a target-*
> guest CPU implementation supports the breakpoint handling. However,
> all our guest CPUs have that support (the only two which do not
> define TARGET_HAS_ICE are unicore32 and openrisc, and in both those
> cases the bp support is present and the lack of the #define is just
> a bug). So remove the #define entirely: all new guest CPU support
> should include breakpoint handling as part of the basic implementation.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
prev parent reply other threads:[~2015-01-05 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 19:09 [Qemu-devel] [PATCH] exec.c: Drop TARGET_HAS_ICE define and checks Peter Maydell
2015-01-05 19:52 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AAEB92.4040602@twiddle.net \
--to=rth@twiddle.net \
--cc=dmorrison@invlim.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).