From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8Dhz-0003pM-9O for qemu-devel@nongnu.org; Mon, 05 Jan 2015 14:53:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8Dhw-0001hA-1Q for qemu-devel@nongnu.org; Mon, 05 Jan 2015 14:52:59 -0500 Received: from mail-qa0-x22f.google.com ([2607:f8b0:400d:c00::22f]:39926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8Dhv-0001g2-TN for qemu-devel@nongnu.org; Mon, 05 Jan 2015 14:52:55 -0500 Received: by mail-qa0-f47.google.com with SMTP id n4so15488220qaq.34 for ; Mon, 05 Jan 2015 11:52:54 -0800 (PST) Sender: Richard Henderson Message-ID: <54AAEB92.4040602@twiddle.net> Date: Mon, 05 Jan 2015 11:52:50 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1420484960-32365-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1420484960-32365-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] exec.c: Drop TARGET_HAS_ICE define and checks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Paolo Bonzini , David Morrison , patches@linaro.org On 01/05/2015 11:09 AM, Peter Maydell wrote: > The TARGET_HAS_ICE #define is intended to indicate whether a target-* > guest CPU implementation supports the breakpoint handling. However, > all our guest CPUs have that support (the only two which do not > define TARGET_HAS_ICE are unicore32 and openrisc, and in both those > cases the bp support is present and the lack of the #define is just > a bug). So remove the #define entirely: all new guest CPU support > should include breakpoint handling as part of the basic implementation. > > Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson r~