From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8R43-0008R4-7n for qemu-devel@nongnu.org; Tue, 06 Jan 2015 05:08:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8R3z-0003kz-7U for qemu-devel@nongnu.org; Tue, 06 Jan 2015 05:08:39 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:54738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8R3y-0003kX-Jv for qemu-devel@nongnu.org; Tue, 06 Jan 2015 05:08:35 -0500 Message-ID: <54ABB34C.4080305@huawei.com> Date: Tue, 6 Jan 2015 18:05:00 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1420523839-11672-1-git-send-email-zhaoshenglong@huawei.com> <1420523839-11672-3-git-send-email-zhaoshenglong@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v3 2/3] hw/arm/virt: Don't add memory node in creat_fdt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: hangaohuai@huawei.com, Claudio Fontana , QEMU Developers , "Huangpeng (Peter)" , ganapatrao.kulkarni@caviumnetworks.com, wanghaibin.wang@huawei.com, Paolo Bonzini , Christoffer Dall On 2015/1/6 17:55, Peter Maydell wrote: > On 6 January 2015 at 05:57, Shannon Zhao wrote: >> To support memory NUMA, don't add memory node in creat_fdt. >> But add it in a new function which takes into accout NUMA >> topology. >> >> Signed-off-by: Shannon Zhao >> --- >> hw/arm/virt.c | 2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c >> index fdafa79..505cd29 100644 >> --- a/hw/arm/virt.c >> +++ b/hw/arm/virt.c >> @@ -190,8 +190,6 @@ static void create_fdt(VirtBoardInfo *vbi) >> * to fill in necessary properties later >> */ >> qemu_fdt_add_subnode(fdt, "/chosen"); >> - qemu_fdt_add_subnode(fdt, "/memory"); >> - qemu_fdt_setprop_string(fdt, "/memory", "device_type", "memory"); >> >> /* Clock node, for the benefit of the UART. The kernel device tree >> * binding documentation claims the PL011 node clock properties are > > This patch will break bisection of all platforms using device tree; > you need to keep things working at all points in your patch series, > not just at the end when all the patches are applied. > Hi Peter, Thanks for your remind. I'll make the patch 2 and 3 together in next version. Thanks, Shannon