From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8UGZ-0000W9-Ez for qemu-devel@nongnu.org; Tue, 06 Jan 2015 08:33:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8UGV-0003qy-Fe for qemu-devel@nongnu.org; Tue, 06 Jan 2015 08:33:47 -0500 Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:48897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8UGV-0003nt-9e for qemu-devel@nongnu.org; Tue, 06 Jan 2015 08:33:43 -0500 Received: by mail-wg0-f43.google.com with SMTP id k14so11614628wgh.16 for ; Tue, 06 Jan 2015 05:33:41 -0800 (PST) Message-ID: <54ABE433.9050102@gmail.com> Date: Tue, 06 Jan 2015 15:33:39 +0200 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1420449663-4542-1-git-send-email-ghammer@redhat.com> In-Reply-To: <1420449663-4542-1-git-send-email-ghammer@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend. Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer , qemu-devel@nongnu.org Cc: Paolo Bonzini On 01/05/2015 11:21 AM, Gal Hammer wrote: > The monitor's auto-completion feature stopped working when stdio is used > as an input and qemu was resumed after it was suspended (using ctrl-z). Thanks Gal, it works now! Tested-by: Marcel Apfelbaum > > Signed-off-by: Gal Hammer > --- > qemu-char.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/qemu-char.c b/qemu-char.c > index ef84b53..786df33 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -1113,12 +1113,22 @@ static int old_fd0_flags; > static bool stdio_in_use; > static bool stdio_allow_signal; > > +static void qemu_chr_set_echo_stdio(CharDriverState *chr, bool echo); > + > static void term_exit(void) > { > tcsetattr (0, TCSANOW, &oldtty); > fcntl(0, F_SETFL, old_fd0_flags); > } > > +static void term_stdio_handler(int sig) > +{ > + if (sig == SIGCONT) { > + /* echo should be off after resume from suspend. */ > + qemu_chr_set_echo_stdio(NULL, false); > + } > +} > + > static void qemu_chr_set_echo_stdio(CharDriverState *chr, bool echo) > { > struct termios tty; > @@ -1165,6 +1175,7 @@ static CharDriverState *qemu_chr_open_stdio(ChardevStdio *opts) > tcgetattr(0, &oldtty); > qemu_set_nonblock(0); > atexit(term_exit); > + signal(SIGCONT, term_stdio_handler); > > chr = qemu_chr_open_fd(0, 1); > chr->chr_close = qemu_chr_close_stdio; >