From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8bN4-00073M-FJ for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:08:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8bN1-0002xT-9E for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:08:58 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41029 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8bN1-0002xA-2S for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:08:55 -0500 Message-ID: <54AC4EE4.7090700@suse.de> Date: Tue, 06 Jan 2015 22:08:52 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1420560191-48029-1-git-send-email-agraf@suse.de> <1420560191-48029-5-git-send-email-agraf@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Rob Herring , "Michael S. Tsirkin" , QEMU Developers , Ard Biesheuvel , Claudio Fontana , Alvise Rigo , Stuart Yoder On 06.01.15 17:16, Peter Maydell wrote: > On 6 January 2015 at 16:03, Alexander Graf wrote: >> Some ARM platforms can successfully map PCI devices into the guest, so it only >> makes sense to also add support for the Bochs virtual VGA adapter on those. >> >> Signed-off-by: Alexander Graf >> --- >> default-configs/arm-softmmu.mak | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak >> index 7671ee2..1581c85 100644 >> --- a/default-configs/arm-softmmu.mak >> +++ b/default-configs/arm-softmmu.mak >> @@ -83,6 +83,7 @@ CONFIG_VERSATILE_PCI=y >> CONFIG_VERSATILE_I2C=y >> >> CONFIG_PCI_GENERIC=y >> +CONFIG_VGA_PCI=y > > Why isn't this just in pci.mak like all the other PCI devices? Honestly, I have no idea. Maybe Michael knows? But if everyone agrees it should be there, I'd be happy to move it. Alex