From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8bUa-0001OI-WD for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:16:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8bUW-0005G7-UR for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:16:44 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41120 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8bUW-0005Fp-O2 for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:16:40 -0500 Message-ID: <54AC50B7.6060108@suse.de> Date: Tue, 06 Jan 2015 22:16:39 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1419604968-87437-1-git-send-email-agraf@suse.de> <1419604968-87437-3-git-send-email-agraf@suse.de> <54AC02F4.40403@redhat.com> In-Reply-To: <54AC02F4.40403@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/5] QJSON: Add JSON writer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, pbonzini@redhat.com, afaerber@suse.de, quintela@redhat.com -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06.01.15 16:44, Eric Blake wrote: > On 12/26/2014 07:42 AM, Alexander Graf wrote: >> To support programmatic JSON assembly while keeping the code that >> generates it readable, this patch introduces a simple JSON >> writer. It emits JSON serially into a buffer in memory. >> >> The nice thing about this writer is its simplicity and low memory >> overhead. Unlike the QMP JSON writer, this one does not need to >> spawn QObjects for every element it wants to represent. >> >> This is a prerequisite for the migration stream format >> description generator. >> >> Signed-off-by: Alexander Graf >> >> --- >> >> v2 -> v3: >> >> - QOMify the QJSON object, makes for easier destruction --- >> include/qjson.h | 3 ++- qjson.c | 39 >> ++++++++++++++++++++++++++++++++++++--- 2 files changed, 38 >> insertions(+), 4 deletions(-) >> >> diff --git a/include/qjson.h b/include/qjson.h index >> 8f8c145..7c54fdf 100644 --- a/include/qjson.h +++ >> b/include/qjson.h @@ -4,7 +4,7 @@ * Copyright Alexander Graf * * >> Authors: - * Alexander Graf > > > Umm, this should be squashed into 1/5. Honestly, I think the whole patch should've gotten squashed into 1/5. I'm not quite sure what went wrong here :). > >> @@ -85,9 +88,7 @@ const char *qjson_get_str(QJSON *json) >> >> QJSON *qjson_new(void) { - QJSON *json = g_new(QJSON, 1); - >> json->str = qstring_from_str("{ "); - json->omit_comma = >> true; + QJSON *json = (QJSON *)object_new(TYPE_QJSON); return >> json; > > This undoes the dangling object that I complained about on patch > 1; maybe there's some more squashing to do?... > > >> +static void qjson_initfn(Object *obj) +{ + QJSON *json = >> (QJSON *)object_dynamic_cast(obj, TYPE_QJSON); + >> assert(json); + + json->str = qstring_from_str("{ "); + >> json->omit_comma = true; > > ...or is it still an incomplete object, just now in a different > location? The idea is that you call finish and only then receive the string. I don't think doing that from get_str would be too much of an improvement - it'd still be wrong if we're in the middle of assembling an object. Alex -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: GPGTools - http://gpgtools.org iQIcBAEBAgAGBQJUrFC2AAoJECszeR4D/txgFUoP/A79amlLyEBoD7/G1jHttwS2 sYKst8ZM+v//dB5Xe+DzU53XgflAkpUoz27zSveluD1A3YQ3zpFYraujaewSn++m sJZS/7bS9WND0vhKdGj41iJXdjxSlHqcdrsKRqYR4MaaTjH8eVoabECS+CcdK0xc R+x08gSUI22+tCKPnudRMm3mlVqJ5O+1KbTYShQQlP5go1p6UN32LONgZ4u9oJPL uQ1vkkrHleHa+RoW4HzRCSO+LQuY/y8CMV1ufS50pILSoX5C/jDdOzqvpc3fR9Ba X1dWVATsF8gk+Hu4sNtWAqiPSsSGg/V0CnBASRYwt/skoNtXoZ++/UWr8B+F/IKc h2UCdO64TlbbDtGYGn/4ZQuUIsGLPvm0yN8J1LshVt85wWJaNe2dw8hirxjzCFoB A6YnueXbaxkHlQkVXL0u2E/EUnmYlRl8JauFBxVDuw6MQecQtc7MIFS0zr8XyKDt IxspJpOKGXAuU7oK+1kmy2aOlMJCVwgdthCv9qDaQl39pTpyF38Jf8kOAFWSkz+C bQqq4EZrI4vMlHcwY4a06YnFH7Ek8Q7YZdFj/W2CIJKsIMh0k79mFjm4r54JrIUF UTXoR/DuZd/zRGLBnj8PoBsfiXk3ZGJCtAyrlns2T32sEbiJmL3lqggiyKzh3+Dd S9NeyhQvJ/xvYPQ89N7p =Zod1 -----END PGP SIGNATURE-----