From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8btf-0005pl-EJ for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:42:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8btY-0006CI-Lt for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:42:39 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41924 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8btY-0006Bz-Fc for qemu-devel@nongnu.org; Tue, 06 Jan 2015 16:42:32 -0500 Message-ID: <54AC56C6.8080905@suse.de> Date: Tue, 06 Jan 2015 22:42:30 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1420560191-48029-1-git-send-email-agraf@suse.de> <1420560191-48029-5-git-send-email-agraf@suse.de> <54AC4EE4.7090700@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Rob Herring , "Michael S. Tsirkin" , QEMU Developers , Ard Biesheuvel , Claudio Fontana , Alvise Rigo , Stuart Yoder On 06.01.15 22:28, Peter Maydell wrote: > On 6 January 2015 at 21:08, Alexander Graf wrote: >> On 06.01.15 17:16, Peter Maydell wrote: >>> On 6 January 2015 at 16:03, Alexander Graf wrote: >>>> +CONFIG_VGA_PCI=y >>> >>> Why isn't this just in pci.mak like all the other PCI devices? >> >> Honestly, I have no idea. Maybe Michael knows? But if everyone agrees it >> should be there, I'd be happy to move it. > > Well, currently the only configs which include pci.mak and don't > also define CONFIG_VGA_PCI are arm, m68k, sh4 and sh4eb, and with > your change arm would move into the other category. It seems more > likely to me that it's just oversight that it's not included in > pci.mak... > > At any rate, given that both sh4 and m68k are pretty much orphan > currently, I don't think anybody's going to notice or complain > about the existence of another PCI device :-) Ok, works for me. I've changed to patch to move the PCI VGA and VGA options to pci.mak. I've not moved CIRRUS or QXL yet though. When I tried, cirrus didn't work - it probably needs access to the legacy VGA regions that don't get mapped with the gpex phb. And for QXL I'd rather have someone put a stamp on it saying that it at least has a remote chance of working ;). Alex