From: Alexander Graf <agraf@suse.de>
To: Marcel Apfelbaum <marcel@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mst@redhat.com, lersek@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 1/6] hw/ppc: modified the condition for usb controllers to be created for some ppc machines
Date: Tue, 06 Jan 2015 22:46:44 +0100 [thread overview]
Message-ID: <54AC57C4.1060400@suse.de> (raw)
In-Reply-To: <1420550957-22337-2-git-send-email-marcel@redhat.com>
On 06.01.15 14:29, Marcel Apfelbaum wrote:
> Some ppc machines create a default usb controller based on a 'machine condition'.
> Until now the logic was: create the usb controller if:
> - the usb option was supplied in cli and value is true or
> - the usb option was absent and both set_defaults and the machine
> condition were true.
>
> Modified the logic to:
> Create the usb controller if:
> - the machine condition is true and defaults are enabled or
> - the usb option is supplied and true.
>
> The main for this is to simplify the usb_enabled method.
>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
I think this preserves the logic from a user's perspective quite well.
Reviewed-by: Alexander Graf <agraf@suse.de>
Alex
next prev parent reply other threads:[~2015-01-06 21:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 13:29 [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 1/6] hw/ppc: modified the condition for usb controllers to be created for some ppc machines Marcel Apfelbaum
2015-01-06 21:46 ` Alexander Graf [this message]
2015-01-06 13:29 ` [Qemu-devel] [PATCH 2/6] hw/machine: added machine_usb wrapper Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 3/6] hw/usb: simplified usb_enabled Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 4/6] hw/ppc/mac_newworld: QOMified mac99 machines Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic Marcel Apfelbaum
2015-01-06 20:45 ` Paolo Bonzini
2015-01-07 11:03 ` Marcel Apfelbaum
2015-01-07 11:07 ` Paolo Bonzini
2015-01-07 11:15 ` Alexander Graf
2015-01-07 11:22 ` Paolo Bonzini
2015-01-07 11:27 ` Alexander Graf
2015-01-07 11:32 ` Paolo Bonzini
2015-01-07 11:37 ` Alexander Graf
2015-01-07 14:57 ` Marcel Apfelbaum
2015-01-07 11:50 ` Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 6/6] hw/ppc/mac_newworld: " Marcel Apfelbaum
2015-01-06 19:48 ` [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash Paolo Bonzini
2015-01-06 20:41 ` Paolo Bonzini
2015-01-06 21:54 ` Alexander Graf
2015-01-07 5:25 ` Paolo Bonzini
2015-01-07 13:15 ` Stefan Hajnoczi
2015-01-08 13:27 ` Peter Maydell
2015-01-08 16:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AC57C4.1060400@suse.de \
--to=agraf@suse.de \
--cc=afaerber@suse.de \
--cc=lersek@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).