From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38649)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1Y8gx0-0006v9-GF
	for qemu-devel@nongnu.org; Tue, 06 Jan 2015 22:06:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1Y8gwx-0005k8-9N
	for qemu-devel@nongnu.org; Tue, 06 Jan 2015 22:06:26 -0500
Received: from fldsmtpe04.verizon.com ([140.108.26.143]:30425)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1Y8gwx-0005j9-6N
	for qemu-devel@nongnu.org; Tue, 06 Jan 2015 22:06:23 -0500
From: Don Slutz <dslutz@verizon.com>
Message-ID: <54ACA2A8.50102@terremark.com>
Date: Tue, 06 Jan 2015 22:06:16 -0500
MIME-Version: 1.0
References: <20150107000121.13777.54926.stgit@gimli.home>
In-Reply-To: <20150107000121.13777.54926.stgit@gimli.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vfio-pci: Fix BAR size overflow
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/06/15 19:03, Alex Williamson wrote:
> We use an unsigned int when working with the PCI BAR size, which can
> obviously overflow if the BAR is 4GB or larger.  This needs to change
> to an unsigned long.  A similar issue is possible, though even more
> unlikely, when mapping the region above an MSI-X table.  The start of
> the table must be below 4GB, but the end, and therefore the start of
> the next mapping region, could still land at 4GB.
>
> Suggested-by: Nishank Trivedi <nishank.trivedi@netapp.com>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>
>   hw/vfio/pci.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index b4e73d1..03790a8 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -2301,7 +2301,7 @@ static void vfio_unmap_bar(VFIOPCIDevice *vdev, int nr)
>   static void vfio_map_bar(VFIOPCIDevice *vdev, int nr)
>   {
>       VFIOBAR *bar = &vdev->bars[nr];
> -    unsigned size = bar->region.size;
> +    unsigned long size = bar->region.size;

On a 32bit build, this does not fix the issue.
     -Don Slutz

>       char name[64];
>       uint32_t pci_bar;
>       uint8_t type;
> @@ -2351,7 +2351,7 @@ static void vfio_map_bar(VFIOPCIDevice *vdev, int nr)
>       }
>   
>       if (vdev->msix && vdev->msix->table_bar == nr) {
> -        unsigned start;
> +        unsigned long start;
>   
>           start = HOST_PAGE_ALIGN(vdev->msix->table_offset +
>                                   (vdev->msix->entries * PCI_MSIX_ENTRY_SIZE));
>
>