From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8qod-0006Bo-9c for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:38:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8qoa-0004YD-4B for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:38:27 -0500 Received: from plane.gmane.org ([80.91.229.3]:58199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8qoZ-0004Vw-St for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:38:24 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Y8krc-00070L-41 for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:17:08 +0100 Received: from net-37-117-147-67.cust.vodafonedsl.it ([37.117.147.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 07 Jan 2015 08:17:08 +0100 Received: from pbonzini by net-37-117-147-67.cust.vodafonedsl.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 07 Jan 2015 08:17:08 +0100 From: Paolo Bonzini Date: Wed, 07 Jan 2015 08:16:44 +0100 Message-ID: <54ACDD5C.1040800@redhat.com> References: <1419421800-27505-1-git-send-email-mst@redhat.com> <1419421800-27505-2-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit In-Reply-To: <1419421800-27505-2-git-send-email-mst@redhat.com> Subject: Re: [Qemu-devel] [PULL 1/8] cpu: add cpu_physical_memory_clear_dirty_range_nocode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Orit Wasserman , dgilbert@redhat.com, Juan Quintela On 24/12/2014 12:51, Michael S. Tsirkin wrote: > simple wrapper so callers don't need to know about > dirty bitmap clients. > > Signed-off-by: Michael S. Tsirkin > --- > include/exec/ram_addr.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h > index 8fc75cd..18ec092 100644 > --- a/include/exec/ram_addr.h > +++ b/include/exec/ram_addr.h > @@ -184,6 +184,14 @@ static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start, > bitmap_clear(ram_list.dirty_memory[client], page, end - page); > } > > +static inline void cpu_physical_memory_clear_dirty_range_nocode(ram_addr_t start, > + ram_addr_t length) > +{ > + cpu_physical_memory_clear_dirty_range(start, length, DIRTY_MEMORY_MIGRATION); > + cpu_physical_memory_clear_dirty_range(start, length, DIRTY_MEMORY_VGA); > +} > + > + > void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t length, > unsigned client); > > The function is not used and goes away in patch 3, so squash it there. Paolo