From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Y8rPV-0007Mo-Cf
	for qemu-devel@nongnu.org; Wed, 07 Jan 2015 09:16:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Y8rPP-00027j-47
	for qemu-devel@nongnu.org; Wed, 07 Jan 2015 09:16:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38521)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Y8rPO-00025w-S5
	for qemu-devel@nongnu.org; Wed, 07 Jan 2015 09:16:27 -0500
Message-ID: <54AD0A80.40303@redhat.com>
Date: Wed, 07 Jan 2015 11:29:20 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1419692504-29373-1-git-send-email-peter@lekensteyn.nl>
	<1419692504-29373-10-git-send-email-peter@lekensteyn.nl>
	<54AAE6CD.9080007@redhat.com>
In-Reply-To: <54AAE6CD.9080007@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 09/10] block/dmg: support bzip2 block entry
 types
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>, Peter Wu <peter@lekensteyn.nl>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>



On 05/01/2015 20:32, John Snow wrote:
>>
>>   fi
>>
>>   ##########################################
>> +# bzip2 check
>> +
>> +if test "$bzip2" != "no" ; then
>> +    cat > $TMPC << EOF
>> +#include <bzlib.h>
>> +int main(void) { BZ2_bzlibVersion(); return 0; }
>> +EOF
>> +    if compile_prog "" "-lbz2" ; then
>> +        libs_softmmu="$libs_softmmu -lbz2"
>> +        bzip2="yes"
>> +    else
>> +        if test "$bzip2" = "yes"; then
>> +            feature_not_found "libbzip2" "Install libbzip2 devel"
>> +        fi
>> +        bzip2="no"
>> +    fi
>> +fi
>> +
>> +##########################################
>>   # libseccomp check
>>
>>   if test "$seccomp" != "no" ; then
>> @@ -4340,6 +4366,7 @@ echo "vhdx              $vhdx"
>>   echo "Quorum            $quorum"
>>   echo "lzo support       $lzo"
>>   echo "snappy support    $snappy"
>> +echo "bzip2 support     $bzip2"
>>   echo "NUMA host support $numa"
>>
>>   if test "$sdl_too_old" = "yes"; then
>> @@ -4695,6 +4722,10 @@ if test "$snappy" = "yes" ; then
>>     echo "CONFIG_SNAPPY=y" >> $config_host_mak
>>   fi
>>
>> +if test "$bzip2" = "yes" ; then
>> +  echo "CONFIG_BZIP2=y" >> $config_host_mak
>> +fi
>> +
>>   if test "$libiscsi" = "yes" ; then
>>     echo "CONFIG_LIBISCSI=m" >> $config_host_mak
>>     echo "LIBISCSI_CFLAGS=$libiscsi_cflags" >> $config_host_mak
>>
> 
> Looks good otherwise. CCing Paolo so he can take a quick peek at the
> configure script. It looks sane to me, though.

It is sane, but instead of libs_softmmu="$libs_softmmu -lbz2" it's
better to follow what we do for libiscsi.  In configure:

CONFIG_BZIP2=y
LIBBZ2_CFLAGS=-lbz2

In Makefile.objs:

dmg.o-libs     := $(LIBBZ2_CFLAGS)

Paolo