From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8qmW-0002pd-A8 for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:36:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8qmQ-0003Yk-2C for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:36:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8qmP-0003YT-Qv for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:36:10 -0500 Message-ID: <54AD137D.4030209@redhat.com> Date: Wed, 07 Jan 2015 12:07:41 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1420550957-22337-1-git-send-email-marcel@redhat.com> <1420550957-22337-6-git-send-email-marcel@redhat.com> <54AC496B.70501@redhat.com> <54AD1271.1080202@redhat.com> In-Reply-To: <54AD1271.1080202@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mst@redhat.com, agraf@suse.de, stefanha@redhat.com, lersek@redhat.com, afaerber@suse.de, rth@twiddle.net On 07/01/2015 12:03, Marcel Apfelbaum wrote: > > While I agree it will be better if we place this in instance_init, > setting the machine_usb to defaults_enabled() there would be problematic > since it depends on > - papr_vga_init(phb->bus) for sparpr and That's effectively vga_interface_type == VGA_DEVICE || vga_interface_type == VGA_STD. > - (PPC_INPUT(env) == PPC_FLAGS_INPUT_970) for mac99. > (The env itself is set in machine_init) Alex, why is auto-USB disabled for 6xx? Can it use vga_interface_type like spapr does? Paolo > Both of those conditions may be available only at machine_init time, > and I am not sure how it would affect those machines.