From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8tHZ-0000Cn-1c for qemu-devel@nongnu.org; Wed, 07 Jan 2015 11:16:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8tHV-00012D-VX for qemu-devel@nongnu.org; Wed, 07 Jan 2015 11:16:28 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39625 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8tHV-00011z-7p for qemu-devel@nongnu.org; Wed, 07 Jan 2015 11:16:25 -0500 Message-ID: <54AD5BD7.2090601@suse.de> Date: Wed, 07 Jan 2015 17:16:23 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1420467812-31917-1-git-send-email-peter.maydell@linaro.org> <20150105205451.4d6a0991@bahia.local> In-Reply-To: <20150105205451.4d6a0991@bahia.local> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] include/qom/cpu.h: Add missing documentation for some CPUClass methods List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz , Peter Maydell Cc: Jens Freimann , qemu-devel@nongnu.org, Anthony Liguori , patches@linaro.org Hi, Am 05.01.2015 um 20:54 schrieb Greg Kurz: > On Mon, 5 Jan 2015 14:23:32 +0000 > Peter Maydell wrote: >=20 >> The CPUClass QOM methods virtio_is_big_endian, write_elf{32,64}_note >> and write_elf{32,64}_qemunote were added without any description >> being added to the doc comment. Correct this omission. >> >> Signed-off-by: Peter Maydell >> --- >=20 > Thanks for this accurate description of virtio_is_big_endian. >=20 > Acked-by: Greg Kurz >=20 >> More informative phrasings for the elf note callbacks welcome... >> >> include/qom/cpu.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/include/qom/cpu.h b/include/qom/cpu.h >> index 2098f1c..f2d7de1 100644 >> --- a/include/qom/cpu.h >> +++ b/include/qom/cpu.h >> @@ -82,6 +82,10 @@ struct TranslationBlock; >> * @do_unassigned_access: Callback for unassigned access handling. >> * @do_unaligned_access: Callback for unaligned access handling, if >> * the target defines #ALIGNED_ONLY. >> + * @virtio_is_big_endian: Callback to return true if a CPU which supp= orts %true >> + * runtime configurable endianness is currently big-endian. Non-confi= gurable >> + * CPUs can use the default implementation of this method. This metho= d should >> + * not be used by any callers other than the pre-1.0 virtio devices. >> * @memory_rw_debug: Callback for GDB memory access. >> * @dump_state: Callback for dumping state. >> * @dump_statistics: Callback for dumping statistics. >> @@ -96,6 +100,14 @@ struct TranslationBlock; >> * @gdb_read_register: Callback for letting GDB read a register. >> * @gdb_write_register: Callback for letting GDB write a register. >> * @debug_excp_handler: Callback for handling debug exceptions. >> + * @write_elf64_note: Callback for writing a CPU-specific ELF note to= a >> + * 64-bit VM coredump. >> + * @write_elf32_qemunote: Callback for writing a CPU- and QEMU-specif= ic ELF >> + * note to a 32 bit VM coredump. >> + * @write_elf32_note: Callback for writing a CPU-specific ELF note to= a >> + * 32-bit VM coredump. >> + * @write_elf32_qemunote: Callback for writing a CPU- and QEMU-specif= ic ELF >> + * note to a 32 bit VM coredump. Let's consistently use "32-bit". :) >> * @vmsd: State description for migration. >> * @gdb_num_core_regs: Number of core registers accessible to GDB. >> * @gdb_core_xml_file: File name for core registers GDB XML descripti= on. Thanks, applied to qom-cpu with those changes: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)