From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9Fu3-000371-Fn for qemu-devel@nongnu.org; Thu, 08 Jan 2015 11:25:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9Ftx-0003sR-Ky for qemu-devel@nongnu.org; Thu, 08 Jan 2015 11:25:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9Ftx-0003s5-BD for qemu-devel@nongnu.org; Thu, 08 Jan 2015 11:25:37 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t08GPZA2022071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 8 Jan 2015 11:25:36 -0500 Message-ID: <54AEAF7E.9050806@redhat.com> Date: Thu, 08 Jan 2015 11:25:34 -0500 From: John Snow MIME-Version: 1.0 References: <1411083819-9284-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1411083819-9284-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com On 09/18/2014 07:43 PM, John Snow wrote: > The original version of the AHCI test base > which is now staged for being merged, processes > the ahci_identify test in a monolithic fashion. > > In authoring new tests, it became necessary and > obvious as to how the operation of this device > should be factored out to ease the writing of > new AHCI tests. > > This patch set issues the necessary refactorings > to support future test development for AHCI. > > This patch set DOES NOT account for any new fixes > and requires no fixes from my "AHCI fixes" RFC > in order to run successfully on 2014-09-18's > origin/master. > > This patch set does not alter the operation of the > existing test, or add new tests. It only offers > refactorings for future patch submissions which > depend on them, but are still under consideration. > > John Snow (15): > qtest/ahci: Add AHCIState structure > qtest/ahci: Add port_select helper > qtest/ahci: Add port_clear helper > qtest/ahci: Add command header helpers > qtest/ahci: Add build cmd table helper > qtest/ahci: Add link_cmd_slot helper > qtest/ahci: Add port_check_error helper > qtest/ahci: Add issue_command helper > qtest/ahci: Add port_check_interrupts helper > qtest/ahci: Add port_check_nonbusy helper > qtest/ahci: Add cmd response sanity check helpers > qtest/ahci: Enforce zero-leaks for guest mem usage > qtest/ahci: Add a macro bootup routine > qtest/ahci: Add human-readable command names > qtest/ahci: Don't use a magic constant for buffer size > > tests/ahci-test.c | 860 ++++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 583 insertions(+), 277 deletions(-) > NACKing my own patchset here because I am preparing a V2 and it is not worth anyone's time to review this version at this point in time. --js