From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9G7n-0002Jy-KT for qemu-devel@nongnu.org; Thu, 08 Jan 2015 11:40:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9G7i-00016O-Mh for qemu-devel@nongnu.org; Thu, 08 Jan 2015 11:39:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9G7i-000165-DX for qemu-devel@nongnu.org; Thu, 08 Jan 2015 11:39:50 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t08GdnL7021439 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 8 Jan 2015 11:39:49 -0500 Message-ID: <54AEB2D4.6030306@redhat.com> Date: Thu, 08 Jan 2015 09:39:48 -0700 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q8bjBJWGQmoLvIfXE6GRiMDxBKivhEaOP" Subject: Re: [Qemu-devel] [PATCH] qemu_opt_get_bool_helper: Fix option handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik , qemu-devel@nongnu.org Cc: stefanha@redhat.com, marcel.a@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q8bjBJWGQmoLvIfXE6GRiMDxBKivhEaOP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/08/2015 09:09 AM, Michal Privoznik wrote: > Well, after 49d2e648e8087 the options to -machine parameter no longer > has .desc nor .desc->type. That's mainly because the options are > dynamically added while .desc is allocated statically. Anyway, if user > tries to run: >=20 > qemu-system-x86_64 -machine pc-i440fx-2.2,accel=3Dkvm,usb=3Doff >=20 > the arguments evaluation fails with: >=20 > qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type =3D= =3D > QEMU_OPT_BOOL' failed. >=20 > Fix this by dropping the assert() which is useless after the mentioned > commit anyway. >=20 > Signed-off-by: Michal Privoznik > --- > util/qemu-option.c | 1 - > 1 file changed, 1 deletion(-) There are several other open threads about this same issue. The consensus so far appears to be that the assert is catching a real bug, and should remain, and that we are instead working on the patches to fix the real bug. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Q8bjBJWGQmoLvIfXE6GRiMDxBKivhEaOP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUrrLUAAoJEKeha0olJ0Nq8VIH/RX3SeSqoj0rJZizHPKz1bZ5 tlFRXo9pxy63N6YITzLkUBsMKvuU45utsTC0PkUT8ruANvDArDENZcPgCKjmXCfK QpaTk5eJP63E5ynPyQt4CgtYTVzBHBYyvvO/1uxVftcuWgt7i9CyXA4dp3NyZIuV PKCAoa7OFP7rAb9U5pyoDU56O6SUxSKp/NykM6UuIZc/rrCNJlUNT1BwVzjFp+gp nnxa6pUsMD1/Q5/DoZVVwRvhW5jcFVZ0ZKFOJ83PBsNcOsNKl3vMS6onOJqJaYAi A2ZDzqvadqwOMv7Oj73FsJIVaKGCTzsA4li6C7F9JragZGSGepvg5TOkqREeXaY= =pHxR -----END PGP SIGNATURE----- --Q8bjBJWGQmoLvIfXE6GRiMDxBKivhEaOP--