From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Y9G9K-0003Vr-Pk
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 11:41:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Y9G9D-0001k2-Sb
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 11:41:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43118)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Y9G9D-0001ju-Jo
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 11:41:23 -0500
Message-ID: <54AEB330.7040005@redhat.com>
Date: Thu, 08 Jan 2015 09:41:20 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1420727405-9587-1-git-send-email-dslutz@verizon.com>
	<CAFEAcA8U38JFPxnYqEZ_E9NkWuvwJv3GnpiiKNp4dY8qNt0wNw@mail.gmail.com>
In-Reply-To: <CAFEAcA8U38JFPxnYqEZ_E9NkWuvwJv3GnpiiKNp4dY8qNt0wNw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="tiR7DIXxqNNAnqM6lGh64wqngukfCB5g6"
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu-img: Add --pkgversion common
	option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Don Slutz <dslutz@verizon.com>
Cc: Kevin Wolf <kwolf@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--tiR7DIXxqNNAnqM6lGh64wqngukfCB5g6
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/08/2015 07:40 AM, Peter Maydell wrote:
> On 8 January 2015 at 14:30, Don Slutz <dslutz@verizon.com> wrote:
>> This will output the QEMU_PKGVERSION which is set by configure's
>> --with-pkgversion=3D
>=20
>> +    /* Report pkgversion */
>> +    if (!strcmp(cmdname, "--pkgversion")) {
>> +        argc--; argv++; /* Drop special arg. */
>> +        printf("qemu-img version " QEMU_VERSION
>> +               " pkgversion " QEMU_PKGVERSION "\n");
>> +        if (argc < 2) {
>> +            return 0;
>> +        }
>> +        cmdname =3D argv[1]; /* Update */
>> +    }
>=20
> Wouldn't it be better to just report the QEMU_PKGVERSION
> as part of the version info we already report in --version?
> This would be consistent with both linux-user and the softmmu
> emulators, which do:
>=20
>  printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ",
> Copyright (c) 2003-2008 Fabrice Bellard\n");

I agree - output the information unconditionally on --version, rather
than inventing a new option.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--tiR7DIXxqNNAnqM6lGh64wqngukfCB5g6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJUrrMwAAoJEKeha0olJ0Nq4H4IAIvLmru8lAeOuZzdprUbKC2W
vyRix4lUbsk+9HOXR+3YzoDi+QzCwdibgLpVrtC8PAQsXcVua54Qm0MSxBlrGCri
mZiUuMMqkxVdEbi0MwLeTTnDgiYupof2J3cDTJi8kRs8/dEUG+cvsGxLDjTivgWH
iMaEFD6E5hgAwiR78qGUFdPUmHYHX3mei5AYWYzsMtBzscyAwWRGHQf0ZwkBc2hg
FRGU4XTDEOAzzYQ0Bdxs76+Snm0mfEY98hKnbE7Y3e1TNTYYjmOVdqI9hYNM62yO
xHys/PmfL8bI46JGRyB/W8ZMqNVHuEfxzw9TOteO51x2F+2CtE8BKxyee3bRgCs=
=MYEU
-----END PGP SIGNATURE-----

--tiR7DIXxqNNAnqM6lGh64wqngukfCB5g6--