From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40377)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Y9Lc9-0001Wc-G3
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 17:31:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Y9Lc6-0007aE-RT
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 17:31:37 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37895)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Y9Lc6-0007a6-K8
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 17:31:34 -0500
Message-ID: <54AF0544.9040205@redhat.com>
Date: Thu, 08 Jan 2015 17:31:32 -0500
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1418307457-25996-1-git-send-email-vsementsov@parallels.com>
	<1418307457-25996-9-git-send-email-vsementsov@parallels.com>
	<54AEFBFF.6070306@redhat.com> <54AF04E2.3070904@redhat.com>
In-Reply-To: <54AF04E2.3070904@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, stefanha@redhat.com



On 01/08/2015 05:29 PM, Eric Blake wrote:
> On 01/08/2015 02:51 PM, John Snow wrote:
>> CC'ing Eric Blake for monitor interface review.
>
> Indeed, I already saw and reviewed the monitor interface in a mail date=
d
> Dec 11.
>

Sorry, I missed that one. Thank you, though :)

>>
>> On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> Add dirty parameter to qmp-migrate command. If this parameter is true=
,
>>> block-migration.c will migrate dirty bitmaps. This parameter can be u=
sed
>>> without "blk" parameter to migrate only dirty bitmaps, skipping block
>>> migration.
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com=
>
>
>>> +        .args_type  =3D "detach:-d,blk:-b,inc:-i,dirty:-D,uri:s",
>>>            .params     =3D "[-d] [-b] [-i] uri",
>>
>> ^ Missing the new -D parameter?
>
> But I missed this point :)  (I've been known to pay less attention to
> HMP than I do to QMP)
>

Sometimes robots miss things, it's fine ;)

--=20
=E2=80=94js