From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] qemu-timer: add timer_init and timer_init_ns/us/ms
Date: Fri, 09 Jan 2015 11:39:50 +0100 [thread overview]
Message-ID: <54AFAFF6.8060306@redhat.com> (raw)
In-Reply-To: <20150109021924.GB6087@fam-t430.nay.redhat.com>
On 09/01/2015 03:19, Fam Zheng wrote:
>> > /**
>> > + * timer_init:
>> > + * @clock: the clock to associate with the timer
> s/@clock/@type/
>
> And similarly below.
Doh, cut-and-paste error (it's also in timer_new and friends).
>> > + * @scale: the scale value for the timer
>> > + * @cb: the callback to call when the timer expires
>> > + * @opaque: the opaque pointer to pass to the callback
>> > + *
>> > + * Create a new timer with the given scale on the default timer list
> s/Create a new/Initialize a/ ?
>
> And similarly below.
Good idea, thanks!
Paolo
next prev parent reply other threads:[~2015-01-09 10:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 10:03 [Qemu-devel] [PATCH 0/4] qemu-timer: introduce usable pointer-free API Paolo Bonzini
2015-01-08 10:03 ` [Qemu-devel] [PATCH 1/4] qemu-timer: rename timer_init to timer_init_tl Paolo Bonzini
2015-01-08 10:03 ` [Qemu-devel] [PATCH 2/4] qemu-timer: add timer_init and timer_init_ns/us/ms Paolo Bonzini
2015-01-09 2:19 ` Fam Zheng
2015-01-09 10:39 ` Paolo Bonzini [this message]
2015-01-08 10:03 ` [Qemu-devel] [PATCH 3/4] qemu-timer: introduce timer_deinit Paolo Bonzini
2015-01-08 10:03 ` [Qemu-devel] [PATCH 4/4] vmstate: accept QEMUTimer in VMSTATE_TIMER*, add VMSTATE_TIMER_PTR* Paolo Bonzini
2015-01-15 9:04 ` Amit Shah
2015-01-15 9:14 ` Paolo Bonzini
2015-01-09 2:10 ` [Qemu-devel] [PATCH 0/4] qemu-timer: introduce usable pointer-free API Fam Zheng
2015-01-09 9:07 ` Paolo Bonzini
2015-01-10 1:35 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AFAFF6.8060306@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).