From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9d55-0002A6-T0 for qemu-devel@nongnu.org; Fri, 09 Jan 2015 12:10:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9d4z-0006dy-Mb for qemu-devel@nongnu.org; Fri, 09 Jan 2015 12:10:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9d4z-0006dq-25 for qemu-devel@nongnu.org; Fri, 09 Jan 2015 12:10:33 -0500 Message-ID: <54B00B84.8080207@redhat.com> Date: Fri, 09 Jan 2015 10:10:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <1420031214-6053-1-git-send-email-den@openvz.org> <20150109170621.8810.42855@loki> In-Reply-To: <20150109170621.8810.42855@loki> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Kq9Ixbt7WRJ0iXaBoHNNwkJ6QID4d3CBM" Subject: Re: [Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec command for Linux List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , "Denis V. Lunev" Cc: Olga Krishtal , qemu-devel@nongnu.org, Semen Zolin This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Kq9Ixbt7WRJ0iXaBoHNNwkJ6QID4d3CBM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/09/2015 10:06 AM, Michael Roth wrote: > The other one worth considering is allowing cmdline to simply be a stri= ng, > to parse it into arguments using g_shell_parse_argv(), which should als= o > be cross-platform. Please no. Passing an unparsed string and asking for platform-specific rules to reparse it is dangerous, compared to requiring the user to pass an array of literal arguments that need no further reparsing. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Kq9Ixbt7WRJ0iXaBoHNNwkJ6QID4d3CBM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUsAuEAAoJEKeha0olJ0NqaD4H/ihhOOrtc7gAzGlibwAkKhxf X3KGSjzP5pcXJRLtMag1LueWiboI2nGRGtFSL1lJtAtNJU1KkmQ2m09JCa9JdV81 LGT7X6RZ6OFOO+U1t9riMnMwosopUJpbuy7rhOxDF1FjOb9MgEr8tLIU2r9W6HJp nJtA3deggq1uy9bNducPkUgvtorYWu3nQCeF5HjX8ezo3gy1+kO0ZUZXdYvVCo0R KJ6DrjXlxiWYu+Rdy0uCqn6xJdUh5hfkasrHnKkp3BJQr1zxVmKpF+hES1e0Nhon GNlDfNJASI0PDY/qwEr4DZcIrnQAh59NyE0NHO+3lVtOXb7qzkr91ai056wEEIA= =Mi2r -----END PGP SIGNATURE----- --Kq9Ixbt7WRJ0iXaBoHNNwkJ6QID4d3CBM--