From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44455)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Y9fjO-0005UC-HJ
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 15:00:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Y9fjK-0004H3-V0
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 15:00:26 -0500
Received: from mail-qc0-x22c.google.com ([2607:f8b0:400d:c01::22c]:64842)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Y9fjK-0004Gs-R9
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 15:00:22 -0500
Received: by mail-qc0-f172.google.com with SMTP id m20so10830081qcx.3
	for <qemu-devel@nongnu.org>; Fri, 09 Jan 2015 12:00:21 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <54B03351.8000405@twiddle.net>
Date: Fri, 09 Jan 2015 12:00:17 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1420797188-20833-1-git-send-email-frediano.ziglio@huawei.com>
In-Reply-To: <1420797188-20833-1-git-send-email-frediano.ziglio@huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] x86_64: optimise muldiv64 for x86_64
	architecture
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Frediano Ziglio <frediano.ziglio@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/09/2015 01:53 AM, Frediano Ziglio wrote:
> As this platform can do multiply/divide using 128 bit precision use
> these instruction to implement it.
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>
> ---
>  include/qemu-common.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/include/qemu-common.h b/include/qemu-common.h
> index f862214..5366220 100644
> --- a/include/qemu-common.h
> +++ b/include/qemu-common.h
> @@ -370,6 +370,7 @@ static inline uint8_t from_bcd(uint8_t val)
>  }
>  
>  /* compute with 96 bit intermediate result: (a*b)/c */
> +#ifndef __x86_64__
>  static inline uint64_t muldiv64(uint64_t a, uint32_t b, uint32_t c)
>  {
>      union {
> @@ -392,6 +393,18 @@ static inline uint64_t muldiv64(uint64_t a, uint32_t b, uint32_t c)
>      res.l.low = (((rh % c) << 32) + (rl & 0xffffffff)) / c;
>      return res.ll;
>  }
> +#else
> +static inline uint64_t muldiv64(uint64_t a, uint32_t b, uint32_t c)
> +{
> +    uint64_t res;
> +
> +    asm ("mulq %2\n\tdivq %3"
> +         : "=a"(res)
> +         : "a"(a), "qm"((uint64_t) b), "qm"((uint64_t)c)
> +         : "rdx", "cc");
> +    return res;
> +}
> +#endif

Honestly, this ought to move into qemu/host-utils.h, and it should
use __int128 for targets that support it.  Which includes x86_64,
but also other 64-bit hosts.


r~