qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 2/6] linux-user/alpha: Add define for NR_shmat to enable shmat syscall
Date: Sat, 10 Jan 2015 13:02:33 -0800	[thread overview]
Message-ID: <54B19369.2020602@twiddle.net> (raw)
In-Reply-To: <CAFEAcA96PSxsfZd=LpFjuN=guYznOiDmfuKWqjYsQB4dSZs9LA@mail.gmail.com>

On 01/10/2015 07:56 AM, Peter Maydell wrote:
>>  #define TARGET_NR_osf_shmat            209
>> +/* this has the usual shmat semantics so give it the name syscall.c expects
>> + * so that our support for it is enabled.
>> + */
>> +#define TARGET_NR_shmat TARGET_NR_osf_shmat

Eh, you could just s/osf_// on this line if you like.
But otherwise looks good.

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

  reply	other threads:[~2015-01-10 21:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 12:19 [Qemu-devel] [PATCH 0/6] linux-user: Fix various clang warnings Peter Maydell
2015-01-08 12:19 ` [Qemu-devel] [PATCH 1/6] linux-user/signal.c: Remove current_exec_domain_sig() Peter Maydell
2015-01-08 12:19 ` [Qemu-devel] [PATCH 2/6] linux-user/alpha: Add define for NR_shmat to enable shmat syscall Peter Maydell
2015-01-10 15:56   ` Peter Maydell
2015-01-10 21:02     ` Richard Henderson [this message]
2015-01-08 12:19 ` [Qemu-devel] [PATCH 3/6] linux-user/arm/nwfpe: Delete unused aCC array Peter Maydell
2015-01-08 12:19 ` [Qemu-devel] [PATCH 4/6] linux-user/main.c: Call cpu_exec_start/end on all target archs Peter Maydell
2015-01-08 12:19 ` [Qemu-devel] [PATCH 5/6] linux-user/main.c: Mark end_exclusive() as possibly unused Peter Maydell
2015-01-21  8:40   ` Thomas Huth
2015-01-21 10:54     ` Peter Maydell
2015-01-08 12:19 ` [Qemu-devel] [PATCH 6/6] linux-user/signal.c: Remove unnecessary wrapper copy_siginfo_to_user Peter Maydell
2015-01-20 14:54 ` [Qemu-devel] [PATCH 0/6] linux-user: Fix various clang warnings Peter Maydell
2015-01-21 10:23   ` Riku Voipio
2015-01-27 19:06     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B19369.2020602@twiddle.net \
    --to=rth@twiddle.net \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).