From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47163)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YA3BD-0006yN-MQ
	for qemu-devel@nongnu.org; Sat, 10 Jan 2015 16:02:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YA3B7-0004Ys-Kt
	for qemu-devel@nongnu.org; Sat, 10 Jan 2015 16:02:43 -0500
Received: from mail-pd0-x232.google.com ([2607:f8b0:400e:c02::232]:39415)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YA3B7-0004Xp-EO
	for qemu-devel@nongnu.org; Sat, 10 Jan 2015 16:02:37 -0500
Received: by mail-pd0-f178.google.com with SMTP id r10so23593567pdi.9
	for <qemu-devel@nongnu.org>; Sat, 10 Jan 2015 13:02:36 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <54B19369.2020602@twiddle.net>
Date: Sat, 10 Jan 2015 13:02:33 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1420719588-8138-1-git-send-email-peter.maydell@linaro.org>	<1420719588-8138-3-git-send-email-peter.maydell@linaro.org>
	<CAFEAcA96PSxsfZd=LpFjuN=guYznOiDmfuKWqjYsQB4dSZs9LA@mail.gmail.com>
In-Reply-To: <CAFEAcA96PSxsfZd=LpFjuN=guYznOiDmfuKWqjYsQB4dSZs9LA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/6] linux-user/alpha: Add define for
 NR_shmat to enable shmat syscall
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, Patch Tracking <patches@linaro.org>

On 01/10/2015 07:56 AM, Peter Maydell wrote:
>>  #define TARGET_NR_osf_shmat            209
>> +/* this has the usual shmat semantics so give it the name syscall.c expects
>> + * so that our support for it is enabled.
>> + */
>> +#define TARGET_NR_shmat TARGET_NR_osf_shmat

Eh, you could just s/osf_// on this line if you like.
But otherwise looks good.

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~