[Qemu-devel] [PATCH] tcg: Add documentation for missing tcg-ops

[Qemu-devel] [PATCH] tcg: Add documentation for missing tcg-ops

[Bastian Koppelmann]

The documentation for the tcg-ops subfi, extr_i64_i32 and extr32_i64 was still
missing.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
 tcg/README | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tcg/README b/tcg/README
index a550ff1..ba40023 100644
--- a/tcg/README
+++ b/tcg/README
@@ -179,6 +179,10 @@ t0=t1+t2
 
 t0=t1-t2
 
+* subfi_i32/i64 t0, const, t1
+
+t0 = const-t1
+
 * neg_i32/i64 t0, t1
 
 t0=-t1 (two's complement)
@@ -353,6 +357,14 @@ from t2 (32 bit).
 Construct t0 (64-bit) taking the low half from t1 (64 bit) and the high half
 from t2 (64 bit).
 
+* extr_i64_i32 t0, t1, t2
+extracts the low half of t2 (64 bit) into t0 (32 bit) and the high half into
+t1 (32 bit).
+
+* extr32_i64 t0, t1, t2
+extracts the low half of t2 (64 bit) into t0 (64 bit) and the high half into
+t1 (64 bit). Both values are not sign extended.
+
 ********* Load/Store
 
 * ld_i32/i64 t0, t1, offset
-- 
2.2.1

Re: [Qemu-devel] [PATCH] tcg: Add documentation for missing tcg-ops

[Richard Henderson]

On 01/10/2015 08:51 AM, Bastian Koppelmann wrote:
> The documentation for the tcg-ops subfi, extr_i64_i32 and extr32_i64 was still
> missing.


No, there are no such tcg ops.

There are *functions* by these names in tcg-op.h, but no opcodes.
If you want to document this sort of thing, it should go elsewhere.


r~

Re: [Qemu-devel] [PATCH] tcg: Add documentation for missing tcg-ops

[Bastian Koppelmann]

Sorry ..., I did not use reply all ...
On 01/10/2015 07:37 PM, Richard Henderson wrote:
> On 01/10/2015 08:51 AM, Bastian Koppelmann wrote:
>> The documentation for the tcg-ops subfi, extr_i64_i32 and extr32_i64 was still
>> missing.
>
> No, there are no such tcg ops.
>
> There are *functions* by these names in tcg-op.h, but no opcodes.
> If you want to document this sort of thing, it should go elsewhere.
>
>
> r~
Fair enough. Where would you recommend to put the documentation?

Cheers,
Bastian

Re: [Qemu-devel] [PATCH] tcg: Add documentation for missing tcg-ops

[Richard Henderson]

On 01/10/2015 01:15 PM, Bastian Koppelmann wrote:
> Fair enough. Where would you recommend to put the documentation?

I don't know.  I don't know where would be most useful.
Perhaps just expanded comments in the header?

Comments might be best, as it'll be easiest to keep up
to date as the code evolves...


r~