* [Qemu-devel] [PATCH] vl.c: fix some alignment issues
@ 2015-01-11 9:37 Marcel Apfelbaum
2015-01-11 10:06 ` Stefan Weil
0 siblings, 1 reply; 3+ messages in thread
From: Marcel Apfelbaum @ 2015-01-11 9:37 UTC (permalink / raw)
To: qemu-trivial; +Cc: qemu-devel
The main's switch had a few cases misaligned.
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
vl.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/vl.c b/vl.c
index 7786b2f..adfdbfd 100644
--- a/vl.c
+++ b/vl.c
@@ -3147,9 +3147,9 @@ int main(int argc, char **argv, char **envp)
case QEMU_OPTION_S:
autostart = 0;
break;
- case QEMU_OPTION_k:
- keyboard_layout = optarg;
- break;
+ case QEMU_OPTION_k:
+ keyboard_layout = optarg;
+ break;
case QEMU_OPTION_localtime:
rtc_utc = 0;
break;
@@ -3357,9 +3357,9 @@ int main(int argc, char **argv, char **envp)
case QEMU_OPTION_debugcon:
add_device_config(DEV_DEBUGCON, optarg);
break;
- case QEMU_OPTION_loadvm:
- loadvm = optarg;
- break;
+ case QEMU_OPTION_loadvm:
+ loadvm = optarg;
+ break;
case QEMU_OPTION_full_screen:
full_screen = 1;
break;
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] vl.c: fix some alignment issues
2015-01-11 9:37 [Qemu-devel] [PATCH] vl.c: fix some alignment issues Marcel Apfelbaum
@ 2015-01-11 10:06 ` Stefan Weil
2015-01-11 10:12 ` Marcel Apfelbaum
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2015-01-11 10:06 UTC (permalink / raw)
To: Marcel Apfelbaum, qemu-trivial; +Cc: qemu-devel
Am 11.01.2015 um 10:37 schrieb Marcel Apfelbaum:
> The main's switch had a few cases misaligned.
>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
> vl.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
The misalignment was caused by tabs which were used instead of spaces.
A short look on vl.c shows lots of more lines with tabs (also in other
switch
statements), so this patch could be extended to fix more lines.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] vl.c: fix some alignment issues
2015-01-11 10:06 ` Stefan Weil
@ 2015-01-11 10:12 ` Marcel Apfelbaum
0 siblings, 0 replies; 3+ messages in thread
From: Marcel Apfelbaum @ 2015-01-11 10:12 UTC (permalink / raw)
To: Stefan Weil, qemu-trivial; +Cc: qemu-devel
On 01/11/2015 12:06 PM, Stefan Weil wrote:
> Am 11.01.2015 um 10:37 schrieb Marcel Apfelbaum:
>> The main's switch had a few cases misaligned.
>>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>> ---
>> vl.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> The misalignment was caused by tabs which were used instead of spaces.
>
> A short look on vl.c shows lots of more lines with tabs (also in other switch
> statements), so this patch could be extended to fix more lines.
This is what I saw while fixing other stuff. :)
I'll try to hunt others and send another version.
Thanks,
Marcel
>
> Stefan
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-11 10:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-11 9:37 [Qemu-devel] [PATCH] vl.c: fix some alignment issues Marcel Apfelbaum
2015-01-11 10:06 ` Stefan Weil
2015-01-11 10:12 ` Marcel Apfelbaum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).