From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52524)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAdsd-00054L-Ir
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:14:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAdsY-0004PW-I1
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:13:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42174)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAdsY-0004PR-9j
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:13:54 -0500
Message-ID: <54B3BA70.3080408@redhat.com>
Date: Mon, 12 Jan 2015 13:13:36 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150112115944.3504.66763.stgit@PASHA-ISP>
	<20150112120111.3504.51955.stgit@PASHA-ISP>
In-Reply-To: <20150112120111.3504.51955.stgit@PASHA-ISP>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com



On 12/01/2015 13:01, Pavel Dovgalyuk wrote:
> +    default:
> +    case QEMU_CLOCK_VIRTUAL:
> +        if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running())
> +            || !replay_checkpoint(run_all ? 2 : 3)) {
> +            return false;
> +        }
> +        break;

Please document the meaning of the numbers by making an enum.  Why do
you have to distinguish run_all?

Paolo