From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAdzN-00085x-Uw for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:21:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAdzH-0006fs-QR for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:20:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAdzH-0006fk-HA for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:20:51 -0500 Message-ID: <54B3BC16.50804@redhat.com> Date: Mon, 12 Jan 2015 13:20:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150112115944.3504.66763.stgit@PASHA-ISP> <20150112120037.3504.44270.stgit@PASHA-ISP> In-Reply-To: <20150112120037.3504.44270.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v7 09/21] replay: asynchronous events infrastructure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com On 12/01/2015 13:00, Pavel Dovgalyuk wrote: > +void replay_flush_events(void) > +{ > + qemu_mutex_lock(&lock); > + while (!QTAILQ_EMPTY(&events_list)) { > + Event *event = QTAILQ_FIRST(&events_list); > + replay_run_event(event); > + QTAILQ_REMOVE(&events_list, event, events); > + g_free(event); > + } > + qemu_mutex_unlock(&lock); replay_run_event must run without the replay mutex, otherwise you risk ABBA deadlocks. Paolo