From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55236)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAe3v-0003vN-FG
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:25:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAe3q-0008Qt-Le
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:25:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43624)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAe3q-0008Qf-Dm
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:25:34 -0500
Message-ID: <54B3BD30.9080407@redhat.com>
Date: Mon, 12 Jan 2015 13:25:20 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150112115944.3504.66763.stgit@PASHA-ISP>
	<20150112120146.3504.82181.stgit@PASHA-ISP>
In-Reply-To: <20150112120146.3504.82181.stgit@PASHA-ISP>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v7 21/21] replay: recording of the user
	input
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com



On 12/01/2015 13:01, Pavel Dovgalyuk wrote:
> +void qemu_input_event_send(QemuConsole *src, InputEvent *evt)
>  {
> -    QemuInputHandlerState *s;
> -
>      if (!runstate_is_running() && !runstate_check(RUN_STATE_SUSPENDED)) {
>          return;
>      }
>  
> +    if (replay_mode == REPLAY_MODE_PLAY) {
> +        /* Nothing */
> +    } else if (replay_mode == REPLAY_MODE_RECORD) {
> +        replay_add_input_event(evt);
> +    } else {
> +        qemu_input_event_send_impl(src, evt);
> +    }

Similar to other cases, please wrap this into a single function,
something like

    if (replay_handle_input_event(evt)) {
        return;
    }

    /* ... original contents of qemu_input_event_send ... */

Paolo