From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60723)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAeNF-0006x7-Ug
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:45:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAeNC-0007KJ-Kg
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:45:37 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37989)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAeNC-0007KD-E4
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:45:34 -0500
Message-ID: <54B3C1DF.8050000@redhat.com>
Date: Mon, 12 Jan 2015 13:45:19 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150112115944.3504.66763.stgit@PASHA-ISP>
	<20150112120054.3504.35220.stgit@PASHA-ISP>
	<54B3BA89.6080705@redhat.com>
	<001401d02e65$5929f180$0b7dd480$@Dovgaluk@ispras.ru>
In-Reply-To: <001401d02e65$5929f180$0b7dd480$@Dovgaluk@ispras.ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and
	replaying clock ticks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com



On 12/01/2015 13:43, Pavel Dovgaluk wrote:
>>> > > +#define REPLAY_CLOCK(clock, value)                                      \
>>> > > +    (replay_mode == REPLAY_MODE_PLAY ? replay_read_clock((clock))       \
>>> > > +        : replay_mode == REPLAY_MODE_RECORD                             \
>>> > > +            ? replay_save_clock((clock), (value))                       \
>>> > > +        : (value))
>>> > > +
>> > 
>> > Inline functions please, not macros.
> Macro is required here, because I do not want the "value" to be computed in
> replay mode at all.

Indeed you're right.

Paolo