From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34589)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAeXa-0000rh-C0
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:56:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAeXW-00023r-S6
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:56:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44960)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAeXW-00023k-KG
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:56:14 -0500
Message-ID: <54B3C44E.4070409@redhat.com>
Date: Mon, 12 Jan 2015 13:55:42 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1416925057-692-1-git-send-email-peter.maydell@linaro.org>
	<54ACCE8B.1090701@redhat.com>
	<CAFEAcA9WexvFn0N=0RtnMRs4okzGS7U6h1DMVJK-5zp1eapqfw@mail.gmail.com>
	<CAFEAcA9FkF+Vh9cA+qQqZQ4NWn4vn7mnDJgbj8Yc=2z6x21A5w@mail.gmail.com>
In-Reply-To: <CAFEAcA9FkF+Vh9cA+qQqZQ4NWn4vn7mnDJgbj8Yc=2z6x21A5w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/6] relicense QEMU softfloat from 2b to to
	2a
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Christophe Lyon <christophe.lyon@st.com>, Patch Tracking <patches@linaro.org>, Richard Sandiford <rdsandiford@googlemail.com>, Juan Quintela <quintela@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Avi Kivity <avi.kivity@gmail.com>, Blue Swirl <blauwirbel@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Paul Brook <paul@codesourcery.com>, Anthony Liguori <aliguori@amazon.com>, Stefan Weil <sw@weilnetz.de>, Guan Xuetao <gxt@mprc.pku.edu.cn>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>



On 12/01/2015 13:53, Peter Maydell wrote:
>>> >> I think we can do that, provided the reimplemented functions are in
>>> >> different places than the originals, so that the revert-and-reimplement
>>> >> is still clear from the diff.
>> >
>> > OK. I'll make sure I do that with the next version.
> Having tried it, this is pretty straightforward for the uint64_to_*
> functions, but the SNAN_BIT_IS_ONE code doesn't work out so nicely,
> because it's removing and reimplementing a lot of #ifdefs inside
> functions, rather than whole functions. We could squash together
> for the commits to master but leave the split commits in the
> tarball archive?

Sure.

Paolo