From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAh3G-0006js-UU
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 10:37:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAh3F-0003Qo-OX
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 10:37:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57871)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YAh3F-0003Qj-GD
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 10:37:09 -0500
Message-ID: <54B3EA1C.2040805@redhat.com>
Date: Mon, 12 Jan 2015 16:37:00 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <3154DC97-3B67-4DBF-BD02-C64E4A9591E3@gmail.com>
	<122C8E58-48F5-4A54-B0AF-A826492D73B6@gmail.com>
	<CAFEAcA_qEXULtxkFu3n+qrQhqVfN_b0VGRgm+=2idW8i=OZVMQ@mail.gmail.com>
	<A3473646-E4D9-4EAB-AE88-3D96074B30C7@gmail.com>
	<CAFEAcA-13UfXA=fY7ty7DFUp2RtRT947Lge3dhX+Qd6w7jwfaQ@mail.gmail.com>
	<4A37A1CE-EE81-4408-A13E-8A4C7C91D498@gmail.com>
	<54AC45AE.5020804@redhat.com>
	<CAKyx-3P-n4S-SeupjcKCi2bvCpt3csGsU=LJ=_JRqwz19x0WjA@mail.gmail.com>
	<54AD0BDE.7020200@redhat.com>
	<1420641833.27381.39.camel@nilsson.home.kraxel.org>
	<67F5B5C0-41E1-4399-8A11-C3821394C31D@gmail.com>
	<1420707776.24470.15.camel@nilsson.home.kraxel.org>
	<07B03389-9719-42C2-A561-05347C36D947@gmail.com>
	<1420793910.24278.6.camel@nilsson.home.kraxel.org>
	<1F47539E-5ACE-4AFD-956B-266FAA04098D@gmail.com>
	<1421053976.8695.13.camel@nilsson.home.kraxel.org>
	<E463F8D8-3DFF-48DF-8EA0-7703077007BE@gmail.com>
	<54B3E419.1070408@redhat.com>
	<CAFEAcA-UQVWNYAGi4cjpX2xXRZMMs1GYDwW7F7JLbUWk0GOWFQ@mail.gmail.com>
In-Reply-To: <CAFEAcA-UQVWNYAGi4cjpX2xXRZMMs1GYDwW7F7JLbUWk0GOWFQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] Gives user ability to select endian
 format for video display - fixes Mac OS X guest color issue.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Programmingkid <programmingkidx@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>



On 12/01/2015 16:14, Peter Maydell wrote:
>> > #ifdef HOST_WORDS_BIGENDIAN
>> > #define PIXMAN_BE_b8g8r8x8     PIXMAN_b8g8r8x8
>> > #else
>> > #define PIXMAN_BE_b8g8r8x8     PIXMAN_x8r8g8b8
>> > #endif
> In qemu-pixman.h, surely? (goes with the existing one we have).

Oh, yes, I wasn't aware of PIXMAN_BE_r8g8b8.

In euther case it is kCGImageAlphaNoneSkipFirst, since the unused bits
are in the most significant bits when interpreted in the "correct"
endianness.

Paolo