qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, thuth@linux.vnet.ibm.com,
	dahi@linux.vnet.ibm.com, armbru@redhat.com,
	Public KVM Mailing List <qemu-devel@nongnu.org>,
	mihajlov@linux.vnet.ibm.com, borntraeger@de.ibm.com,
	stefanha@redhat.com, cornelia.huck@de.ibm.com,
	pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.
Date: Tue, 13 Jan 2015 12:59:43 +0300	[thread overview]
Message-ID: <54B4EC8F.2030408@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150102113001.GB10823@stefanha-thinkpad.redhat.com>

On 01/02/2015 02:30 PM, Stefan Hajnoczi wrote:
> On Thu, Dec 18, 2014 at 12:17:59PM +0100, Ekaterina Tumanova wrote:
>> Updates v4 -> v5:
>>
>> Minor Updates according the last review from Markus:
>> 1. update commit message for patch 2
>> 2. fix comment typos
>> 3. fix check_for_dasd to return -1 instead of -ENOTSUP
>>
>> Thanks,
>> Kate.
>>
>> ---------------------------------------------------------------
>>     Patchset Description (didn't change):
>>
>> Proper geometry and blocksize information is vital for support of
>> DASD/ECKD drives in Linux guests. Otherwise things will fail in
>> certain cases.
>>
>> The existing geometry and blocksize qemu defaults have no sense
>> for DASD drives (hd_geometry_guess detection and 512 for sizes).
>> Setting this information manually in XML file is far from user-friendly,
>> as the admin has to manually look up the properties of the
>> host disks and then modify the guest definition accordingly.
>
> What is the expected behavior when you dd the disk image from the DASD
> to a raw image file on an NFS file system on the host?
>
> It seems you'd lose the geometry detection and the disk image could be
> unusable from inside the guest.
>

This patch set doesn't change the handling of the images, dd'ed from
DASDs. Please refer to Christian's reply for details.

Thanks a lot for you review!

Kate.

      reply	other threads:[~2015-01-13  9:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 11:17 [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices Ekaterina Tumanova
2014-12-18 11:18 ` [Qemu-devel] [PATCH v5 1/5] block: add bdrv functions for geometry and blocksize Ekaterina Tumanova
2014-12-18 11:18 ` [Qemu-devel] [PATCH v5 2/5] raw-posix: Refactor logical block size detection Ekaterina Tumanova
2015-01-02 11:52   ` Stefan Hajnoczi
2015-01-13 10:03     ` Ekaterina Tumanova
2015-01-13 15:24       ` Stefan Hajnoczi
2014-12-18 11:18 ` [Qemu-devel] [PATCH v5 3/5] block: Add driver methods to probe blocksizes and geometry Ekaterina Tumanova
2014-12-18 12:43   ` Thomas Huth
2015-01-02 12:11   ` Stefan Hajnoczi
2014-12-18 11:18 ` [Qemu-devel] [PATCH v5 4/5] block-backend: Add wrappers for blocksizes and geometry probing Ekaterina Tumanova
2014-12-18 14:45   ` Thomas Huth
2015-01-02 12:34   ` Stefan Hajnoczi
2014-12-18 11:18 ` [Qemu-devel] [PATCH v5 5/5] BlockConf: Call backend functions to detect geometry and blocksizes Ekaterina Tumanova
2014-12-18 14:55   ` Thomas Huth
2015-01-02 12:46   ` Stefan Hajnoczi
2014-12-18 15:59 ` [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices Christian Borntraeger
2015-01-02 12:57   ` Stefan Hajnoczi
2015-01-13  8:32     ` Christian Borntraeger
2015-01-13 10:51       ` Markus Armbruster
2015-01-13 16:04         ` Stefan Hajnoczi
2015-01-13 17:27           ` Markus Armbruster
2015-01-13 19:07           ` Christian Borntraeger
2015-01-14 13:57             ` Stefan Hajnoczi
2015-01-02 11:30 ` Stefan Hajnoczi
2015-01-13  9:59   ` Ekaterina Tumanova [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B4EC8F.2030408@linux.vnet.ibm.com \
    --to=tumanova@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dahi@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mihajlov@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    --cc=thuth@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).