From: Stefan Weil <sw@weilnetz.de>
To: Markus Armbruster <armbru@redhat.com>,
Zhang Min <rudy.zhangmin@huawei.com>
Cc: lizhengui@huawei.com, fangyi.fangyi@huawei.com,
hz.wangzhiwei@huawei.com, subo7@huawei.com,
kathy.wangting@huawei.com, qemu-devel@nongnu.org,
wu.wubin@huawei.com, boby.chen@huawei.com, wangjie88@huawei.com,
pbonzini@redhat.com, shiweixian@huawei.com, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH] vl.c: optimized code format
Date: Tue, 13 Jan 2015 13:47:35 +0100 [thread overview]
Message-ID: <54B513E7.90704@weilnetz.de> (raw)
In-Reply-To: <87iogb10n4.fsf@blackfin.pond.sub.org>
Am 13.01.2015 um 10:38 schrieb Markus Armbruster:
> Zhang Min <rudy.zhangmin@huawei.com> writes:
>
>> From: Rudy Zhang <rudy.zhangmin@huawei.com>
>>
>> There are several tab characters in the 'vl.c' file. It leads to
>> to misalignment of the code. So, let the space instead of the tab.
>>
>> Signed-off-by: Rudy Zhang <rudy.zhangmin@huawei.com>
> While we don't want tabs in new code, we generally leave existing ones
> alone until we need to touch the line anyway, or the tabs get in the way
> somehow.
True. In this special case, there is already a similar patch queued for
qemu-trivial, so Zhang Min's patch is not needed. As far as I know, that
previous patch was sent to prepare further modifications in vl.c, that's
why I acked it.
Stefan
prev parent reply other threads:[~2015-01-13 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 5:18 [Qemu-devel] [PATCH] vl.c: optimized code format Zhang Min
2015-01-13 9:38 ` Markus Armbruster
2015-01-13 12:47 ` Stefan Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B513E7.90704@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=boby.chen@huawei.com \
--cc=fangyi.fangyi@huawei.com \
--cc=hz.wangzhiwei@huawei.com \
--cc=kathy.wangting@huawei.com \
--cc=lizhengui@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rudy.zhangmin@huawei.com \
--cc=shiweixian@huawei.com \
--cc=subo7@huawei.com \
--cc=wangjie88@huawei.com \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).