From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB4af-00054b-8D for qemu-devel@nongnu.org; Tue, 13 Jan 2015 11:45:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB4aZ-0005bb-LU for qemu-devel@nongnu.org; Tue, 13 Jan 2015 11:45:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB4aZ-0005aV-FG for qemu-devel@nongnu.org; Tue, 13 Jan 2015 11:45:07 -0500 Message-ID: <54B54B91.6070808@redhat.com> Date: Tue, 13 Jan 2015 11:45:05 -0500 From: John Snow MIME-Version: 1.0 References: <1419297142-24282-1-git-send-email-jsnow@redhat.com> <1419297142-24282-7-git-send-email-jsnow@redhat.com> <54A2ACF7.2020302@parallels.com> <54B09BAF.9040909@redhat.com> <54B4EB71.7000807@parallels.com> <54B549B9.2060105@redhat.com> <54B54B38.6080800@parallels.com> In-Reply-To: <54B54B38.6080800@parallels.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v10 06/13] block: Add bdrv_copy_dirty_bitmap and bdrv_clear_dirty_bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com On 01/13/2015 11:43 AM, Vladimir Sementsov-Ogievskiy wrote: > No, I'm saying about adding comment about using size in sectors and > granularity in bytes in BdrvDirtyBitmap structure. I'm sorry, I misunderstood. It's at the end of the series, as a fixup patch. > > On 10.01.2015 06:25, John Snow wrote: > ...... >> What I will do instead is just to document this quirk. Look out for V1= 1 > > Best regards, > Vladimir > > On 13.01.2015 19:37, John Snow wrote: >> >> On 01/13/2015 04:54 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Hmm, can't find it in v11 >>> >>> Best regards, >>> Vladimir >>> >> >> I changed approach and instead of copying bitmaps to be used with the >> incremental backup, I lock them in place. So copy isn't used anymore >> in my set, so the name of the patch changed. >> >> --js > --=20 =E2=80=94js