From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB6oH-0000Hm-Rq for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:07:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB6oE-0005xy-A6 for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:07:25 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:56048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB6oD-0005xc-W9 for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:07:22 -0500 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Jan 2015 19:07:19 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id A633B2190041 for ; Tue, 13 Jan 2015 19:06:45 +0000 (GMT) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t0DJ7H0s54198372 for ; Tue, 13 Jan 2015 19:07:17 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t0DJ7Geg014163 for ; Tue, 13 Jan 2015 12:07:17 -0700 Message-ID: <54B56CE3.6020309@de.ibm.com> Date: Tue, 13 Jan 2015 20:07:15 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1418901484-12988-1-git-send-email-tumanova@linux.vnet.ibm.com> <5492F9F6.3060004@de.ibm.com> <20150102125747.GG10823@stefanha-thinkpad.redhat.com> <54B4D816.6010507@de.ibm.com> <87mw5nx8ag.fsf@blackfin.pond.sub.org> <20150113160403.GB26676@stefanha-thinkpad.redhat.com> In-Reply-To: <20150113160403.GB26676@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, thuth@linux.vnet.ibm.com, Stefan Hajnoczi , Ekaterina Tumanova , Public KVM Mailing List , Markus Armbruster , dahi@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, mihajlov@linux.vnet.ibm.com Am 13.01.2015 um 17:04 schrieb Stefan Hajnoczi: [...] > I'm really starting to get worried that you are going to break things. > This DASD hack is a layering violation but okay, go ahead if you want. > But now you are also thinking about breaking live migration. > > The proper thing to do is to introduce libvirt XML syntax for DASD. > That way the geometry can be handled as part of the machine > configuration. Then live migration and storage management tools can do > the right thing. > > I've said this should be done in libvirt repeatedly but you keep wanting > to hack QEMU instead of doing this cleanly :(. > > If you have plans to expand on this hack, please scrap this series and > introduce libvirt XML syntax instead. We had no plans to expand on this band-aid. I just tried to come up with ideas beyond this hack to make this more acceptible to you (because I though that you want something on top). Seems that I misunderstood you, so if you prefer to just keep this hack and not do anything further in that direction, this is totally fine with me. So lets just fix up the small nits and go ahead, ok? Christian