From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58573)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YB7SE-0005sb-9T
	for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:48:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YB7SB-0004jd-4m
	for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:48:42 -0500
Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:57479)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YB7SA-0004jN-TF
	for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:48:39 -0500
Received: by mail-wi0-f176.google.com with SMTP id ex7so23749239wid.3
	for <qemu-devel@nongnu.org>; Tue, 13 Jan 2015 11:48:37 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <54B57691.4020007@redhat.com>
Date: Tue, 13 Jan 2015 20:48:33 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1421171537-19118-1-git-send-email-pbonzini@redhat.com>	<1421171537-19118-2-git-send-email-pbonzini@redhat.com>
	<CAFEAcA-W9-dVCGbqwgftPE3gk8p-_Gf2Qz2fOUHr+QXpfgxfvQ@mail.gmail.com>
In-Reply-To: <CAFEAcA-W9-dVCGbqwgftPE3gk8p-_Gf2Qz2fOUHr+QXpfgxfvQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for
	__thread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Fam Zheng <famz@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>



On 13/01/2015 19:40, Peter Maydell wrote:
> On 13 January 2015 at 17:52, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> The block layer is now using __thread unconditionally.
> 
> Where? I did a quick grep for __thread and (other than stuff in
> the *-user code and some Win32 specific files) there's no use of
> __thread outside the DEFINE_TLS wrappers.

It's in the pull request.

>>  Remove the
>> "fake" TLS wrappers (that actually aren't TLS on !Linux) in
>> include/qemu/tls.h, and add a testcase.
> 
> What platforms have you tested on? We definitely shouldn't
> widen our use of __thread without testing it on all the
> platforms we support...

Native TLS is supported by all platforms except Windows and, I think,
OpenBSD, which will have to use GCC's emulated TLS.  For Windows we
already do.  OpenBSD ports will have to use a new-enough GCC (basically
depend on the GPLv3 GCC port).

Paolo