From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB7Sy-0006to-2e for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:49:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB7Sx-000507-8Y for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:49:28 -0500 Sender: Paolo Bonzini Message-ID: <54B576BF.80409@redhat.com> Date: Tue, 13 Jan 2015 20:49:19 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1420652355-31847-1-git-send-email-pbonzini@redhat.com> <1420652355-31847-2-git-send-email-pbonzini@redhat.com> <20150113184830.GE31510@thinpad.lan.raisama.net> In-Reply-To: <20150113184830.GE31510@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org On 13/01/2015 19:48, Eduardo Habkost wrote: >> > if (b1 & 1) { >> > - gen_stq_env_A0(s, offsetof(CPUX86State, xmm_regs[reg])); >> > + gen_stq_env_A0(s, offsetof(CPUX86State, >> > + xmm_regs[reg].XMM_Q(0))); > Do we have (or will patch 4/4 introduce) the same bug on the > tcg_gen_addi_ptr() calls that don't use the XMM_Q macro? No, they all call into helpers that use the XMM_Q macro themselves. Paolo