From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB7TY-0007tz-A2 for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:50:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB7TX-0005MF-7R for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:50:04 -0500 Received: from mail-wg0-x236.google.com ([2a00:1450:400c:c00::236]:46312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB7TW-0005LH-Ua for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:50:03 -0500 Received: by mail-wg0-f54.google.com with SMTP id z12so4981303wgg.13 for ; Tue, 13 Jan 2015 11:50:02 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54B576E7.6050203@redhat.com> Date: Tue, 13 Jan 2015 20:49:59 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1420652355-31847-1-git-send-email-pbonzini@redhat.com> <1420652355-31847-3-git-send-email-pbonzini@redhat.com> <20150113183734.GD31510@thinpad.lan.raisama.net> In-Reply-To: <20150113183734.GD31510@thinpad.lan.raisama.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org On 13/01/2015 19:37, Eduardo Habkost wrote: >> > + tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + offsetof(XMMReg, XMM_Q(1)); >> > + tcg_gen_st_i64(cpu_tmp1_i64, cpu_env, d_offset + offsetof(XMMReg, XMM_Q(1)); > It looks good (I even sent my Reviewed-by line), but: > > target-i386/translate.c:2624:88: error: expected ‘)’ before ‘;’ token > tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + offsetof(XMMReg, XMM_Q(0)); > ^ This sounds familiar. I had attached the wrong version of the series, but the only difference is the two extra parentheses. Paolo