From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB7UJ-0000iV-1i for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:50:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB7UF-0005vJ-S9 for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:50:50 -0500 Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:41577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB7UF-0005uv-Ll for qemu-devel@nongnu.org; Tue, 13 Jan 2015 14:50:47 -0500 Received: by mail-wg0-f41.google.com with SMTP id l18so5029477wgh.0 for ; Tue, 13 Jan 2015 11:50:46 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54B57712.9070203@redhat.com> Date: Tue, 13 Jan 2015 20:50:42 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1421173921-28848-1-git-send-email-peter.maydell@linaro.org> <1421173921-28848-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1421173921-28848-2-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] cpu_ldst.h: Remove unused ldul_ macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org, Richard Henderson On 13/01/2015 19:32, Peter Maydell wrote: > The five ldul_ macros are not used anywhere and are marked up with an XXX > comment. "ldul" is a non-standard prefix for our family of load instructions: > we don't mark 32-bit accesses for signedness because they return a 32 bit > quantity. So just delete them. > > Signed-off-by: Peter Maydell > --- > include/exec/cpu_ldst.h | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h > index e5550e7..4700831 100644 > --- a/include/exec/cpu_ldst.h > +++ b/include/exec/cpu_ldst.h > @@ -151,15 +151,6 @@ > > #else > > -/* XXX: find something cleaner. > - * Furthermore, this is false for 64 bits targets > - */ > -#define ldul_user ldl_user > -#define ldul_kernel ldl_kernel > -#define ldul_hypv ldl_hypv > -#define ldul_executive ldl_executive > -#define ldul_supervisor ldl_supervisor > - > /* The memory helpers for tcg-generated code need tcg_target_long etc. */ > #include "tcg.h" > > Trivial, even. Reviewed-by: Paolo Bonzini