From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>, Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts
Date: Wed, 14 Jan 2015 08:37:58 +0100 [thread overview]
Message-ID: <54B61CD6.7010303@redhat.com> (raw)
In-Reply-To: <1421197016-69426-1-git-send-email-agraf@suse.de>
On 14/01/2015 01:56, Alexander Graf wrote:
> + if (sizeof(pool) == 4) {
> + /* 32bit systems run out of virtual memory quickly */
> + pool->max_threads = 4;
> + } else {
> + pool->max_threads = 64;
> + }
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
The same problem applies to coroutine stacks, and those cannot be
throttled down as easily. But I guess if you limit the number of
threads, the guest gets slowed down and doesn't create as many coroutines.
It would be nice to have a way to measure coroutine stack usage, similar
to what the kernel does.
Paolo
next prev parent reply other threads:[~2015-01-14 7:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 0:56 [Qemu-devel] [PATCH] AIO: Reduce number of threads for 32bit hosts Alexander Graf
2015-01-14 7:37 ` Paolo Bonzini [this message]
2015-01-14 10:20 ` Kevin Wolf
2015-01-14 11:18 ` Paolo Bonzini
2015-01-14 13:38 ` Kevin Wolf
2015-01-14 13:49 ` Paolo Bonzini
2015-01-14 14:07 ` Kevin Wolf
2015-01-14 14:09 ` Alexander Graf
2015-01-15 10:00 ` Kevin Wolf
2015-01-14 14:24 ` Markus Armbruster
2015-02-12 15:38 ` Stefan Hajnoczi
2015-02-12 15:59 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B61CD6.7010303@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).