From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBNiy-0004uo-G1 for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:11:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBNis-0001Mk-6I for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:11:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBNir-0001MT-Su for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:10:58 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0EDAva4018810 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 14 Jan 2015 08:10:57 -0500 Message-ID: <54B66AE0.1060408@redhat.com> Date: Wed, 14 Jan 2015 06:10:56 -0700 From: Eric Blake MIME-Version: 1.0 References: <1421171432-8733-1-git-send-email-armbru@redhat.com> <1421171432-8733-2-git-send-email-armbru@redhat.com> In-Reply-To: <1421171432-8733-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lUl4neE3semeb0GlL05VX00kXCnc5IRmj" Subject: Re: [Qemu-devel] [PATCH 1/9] qmp hmp: Factor out common "using spice" test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kraxel@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lUl4neE3semeb0GlL05VX00kXCnc5IRmj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/13/2015 10:50 AM, Markus Armbruster wrote: > Into qemu_using_spice(). For want of a better place, put it next the > existing monitor command handler dummies in qemu-spice.h. >=20 > Signed-off-by: Markus Armbruster > --- > include/ui/qemu-spice.h | 10 ++++++++++ > monitor.c | 5 +++-- > qmp.c | 11 +++-------- > 3 files changed, 16 insertions(+), 10 deletions(-) >=20 > diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h > index a93b4b2..b3f2679 100644 > --- a/include/ui/qemu-spice.h > +++ b/include/ui/qemu-spice.h > @@ -88,4 +88,14 @@ static inline int qemu_spice_display_add_client(int = csock, int skipauth, > =20 > #endif /* CONFIG_SPICE */ > =20 > +static inline int qemu_using_spice(Error **errp) Why not s/int/bool/ > +{ > + if (!using_spice) { > + /* correct one? spice isn't a device ,,, */ > + error_set(errp, QERR_DEVICE_NOT_ACTIVE, "spice"); > + return 0; > + } > + return 1; and use true/false here? All callers use it only in a boolean context. Either way, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lUl4neE3semeb0GlL05VX00kXCnc5IRmj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUtmrgAAoJEKeha0olJ0NqimoH+wV9UFaTBmP5qsuqYomidgJk b3e28H37Z50RQu+63Y1K8bn4QgbBOWK7kta0Lo4MdKHkT0jjQdbi5gb/63j4qOxR EgpxX/BPPyV+NBWSSPIRe9An5B95mBqQ1KIBU3/oSYJmh56rAJclKtGYXPkL0jF5 FF8alOPBM47LmQ0sqeGXXBR5oh8aEAnTyhTN/eD0vCzY5uH6ymM2/94Nrjw/rFhs 8IREWMi14vI56PO3J9c9mRYiObRvYJ5JT7b8QKkUUO/4poU/qThHIok9SnPVdzwJ NG1eHNNAWmRidGIum4+14+gHxGUD6/A1LjC+Rsd/himwgQQAWi6z320AsYsDOE0= =IxV8 -----END PGP SIGNATURE----- --lUl4neE3semeb0GlL05VX00kXCnc5IRmj--