From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBPvf-0004S0-M4 for qemu-devel@nongnu.org; Wed, 14 Jan 2015 10:32:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBPvY-00026G-SR for qemu-devel@nongnu.org; Wed, 14 Jan 2015 10:32:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBPvY-00025x-LK for qemu-devel@nongnu.org; Wed, 14 Jan 2015 10:32:12 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0EFWAT4014194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 14 Jan 2015 10:32:10 -0500 Message-ID: <54B68BF9.5090308@redhat.com> Date: Wed, 14 Jan 2015 08:32:09 -0700 From: Eric Blake MIME-Version: 1.0 References: <1421245910-30666-1-git-send-email-armbru@redhat.com> In-Reply-To: <1421245910-30666-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1VWPGVUWWktSwkXgHDFVvwJKSgVfU6VMv" Subject: Re: [Qemu-devel] [PATCH 0/4] block: Cleanups around error reporting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1VWPGVUWWktSwkXgHDFVvwJKSgVfU6VMv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/14/2015 07:31 AM, Markus Armbruster wrote: > Markus Armbruster (4): > blockdev: Give find_block_job() an Error ** parameter > blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro > block: New bdrv_add_key(), convert monitor to use it > block: Eliminate silly QERR_ macros used for encryption keys Reviewed-by: Eric Blake >=20 > block.c | 31 +++++++++++++++++++++++++++++++ > blockdev.c | 44 +++++++++++----------------------------= ----- > include/block/block.h | 1 + > include/qapi/qmp/qerror.h | 9 --------- > monitor.c | 16 +++++++++++----- > qmp.c | 8 ++++---- > 6 files changed, 58 insertions(+), 51 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1VWPGVUWWktSwkXgHDFVvwJKSgVfU6VMv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUtov5AAoJEKeha0olJ0NqDXcIAJLgeMnh5g/Nvb3pIrilZHwz bmfsce9o6vEb5o/E4YPJLL4ZHxJDKl83tbVZpr/6K8QROOnj77B5TMltf1i0PUjs 2EXlBgq3DcvgY+RX+KSIZPgE2pqfGwbK+RFFcO0M59gBAs6I72Mlg1xhYaH3Ag5m CPZ5w19DBqjScSIeq7ag3YQa02ieCqsR+SGZnw8C5tcmauDM4gp6Hh0tKMnr4+M1 9LD3E38M2csp/EaIraq1PhByrEtgnz5eFaCa6yhYjiKunu5E0VX7kqCO/0sgCmq9 SIMxixIS/nHf7gkdp3uKZEm3mN5LsivdbrxANBBthVlDNesOh+gipU9mHC8pb7A= =vIdn -----END PGP SIGNATURE----- --1VWPGVUWWktSwkXgHDFVvwJKSgVfU6VMv--